From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 09/10] box/journal: journal_entry_new -- drop setting up callbacks
Date: Sat, 7 Mar 2020 00:57:55 +0300 [thread overview]
Message-ID: <20200306215755.GC27301@uranus> (raw)
In-Reply-To: <20200306215103.GK8140@atlas>
On Sat, Mar 07, 2020 at 12:51:03AM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [20/03/07 00:44]:
> > But vinyl test case fails
> >
> > 2020-03-07 00:35:51.116 [6494] main/136/applier/unix/:/home/cyrill/sda1 I> subscribed
> > 2020-03-07 00:35:51.116 [6494] main/136/applier/unix/:/home/cyrill/sda1 I> remote vclock {1: 782} local vclock {1: 382}
> > tarantool: /home/cyrill/sda1/tarantool/tarantool.git/src/box/vy_tx.c:803: void vy_tx_commit(struct vy_tx *, int64_t): Assertion `xm->lsn <= lsn' failed.
> > [001] replication/gc.test.lua vinyl
>
> This has to do most likely with out-of-order invocation of the
> wakeup callbacks.
>
> Are these sync callbacks or async callbacks?
To be honest -- I don't know at the moment. This is replication test
if I understand correctly and I presume these are async calls, but
not sure yet. What is interesting is that vinyl internally use
journal entries and calls cbus directly to write the data (again,
if I understand correctly 'cause I know nothing about vinyl internals)
and this might be the reason.
> When a batch of transactions are submitted to wal, they got to be
> scheduled to commit in the order of their lsn.
>
> the order gets broken here for some reason. Please find out why.
Yes. Will continue the next week. And thanks a huge for all your
comments. I'll try to address them in next series once I finish
hunting this test issue.
You know this series of patches is a bit ugly but once we have
a working set of patches we will beautify them the way we like.
next prev parent reply other threads:[~2020-03-06 21:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 12:29 [Tarantool-patches] [PATCH 00/10] box/journal: redesign sync and async writes Cyrill Gorcunov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 01/10] box: recovery_journal_create -- set journal here Cyrill Gorcunov
2020-03-06 21:27 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 02/10] box/txn: move fiber_set_txn to header Cyrill Gorcunov
2020-03-06 21:27 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 03/10] box/txn: rename txn_write to txn_commit_async Cyrill Gorcunov
2020-03-06 21:28 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 04/10] box/txn: move setup of txn start to txn_prepare Cyrill Gorcunov
2020-03-06 21:30 ` Konstantin Osipov
2020-03-18 12:38 ` Cyrill Gorcunov
2020-03-18 13:58 ` Konstantin Osipov
2020-03-18 14:09 ` Cyrill Gorcunov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 05/10] box/txn: add txn_commit_nop helper Cyrill Gorcunov
2020-03-06 21:30 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 06/10] box/txn: unweave txn_commit from txn_commit_async Cyrill Gorcunov
2020-03-06 21:33 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 07/10] box/txn: clear fiber storage right before journal write Cyrill Gorcunov
2020-03-06 21:34 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 08/10] box/txn: move journal allocation into separate routine Cyrill Gorcunov
2020-03-06 21:35 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 09/10] box/journal: journal_entry_new -- drop setting up callbacks Cyrill Gorcunov
2020-03-06 21:37 ` Konstantin Osipov
2020-03-06 21:41 ` Cyrill Gorcunov
2020-03-06 21:51 ` Konstantin Osipov
2020-03-06 21:57 ` Cyrill Gorcunov [this message]
2020-03-06 22:04 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 10/10] box/journal: redesign sync and async writes Cyrill Gorcunov
2020-03-06 21:48 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306215755.GC27301@uranus \
--to=gorcunov@gmail.com \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 09/10] box/journal: journal_entry_new -- drop setting up callbacks' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox