Re: [Tarantool-patches] [PATCH v2] iproto: add an empty body to the unprepare response

[Alexander Turenko <alexander.turenko@tarantool.org>]

> > Technically there are two ways to extract helpers from a 'core =
> > tarantool' test:
> > 
> > * Add it to, say, test/box/box.lua and to _G.protected_globals.
> > * Add it to a separate Lua file in test/box/lua and to 'lua_libs' field
> >  in test/box/suite.ini. After this you can use `require` for this
> >  module in a test.
> 
> This also seems like a fine solution, if we are to stick to the SOP, I will do this.

It is our process. We should follow it or at least provide strong
reasoning why we shouldn't in a particular case.

> However, I’m not sure whether this patch fixes a bug, it is stated in the code
> that there’s nothing to send in case of unprepare, perhaps it is a feature?

The issue is marked with 'bug' label.

'unprepare' is the only request, which does not contain a body. In
1.6.4-128-gf433f4b0a (see [1]) it was decided to always send a body in a
response and 'unprepare' does not fit this property. It is unexpected
behaviour and it is what we usually call a bug.

[1]: https://github.com/tarantool/tarantool/commit/f433f4b0aeab48be9b5259b6c5065091dbf07553

WBR, Alexander Turenko.