From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] test: fix fio.test.lua flakiness
Date: Fri, 6 Mar 2020 18:45:03 +0300 [thread overview]
Message-ID: <20200306154503.mjz5f47p3jyrb3v5@tarantool.org> (raw)
In-Reply-To: <4ecccbd1294ac024dfc9c05d2d7f74b908e50992.1583442898.git.v.shpilevoy@tarantool.org>
Hello,
On 05 мар 22:15, Vladislav Shpilevoy wrote:
> In 89c73e64c071cb7402406bf1eb8d767d4dfe4e6e ("fio: respect
> $TMPDIR in fio.tempdir(), when it is set") was added a test
> checking that fio.tempdir() returns a path to a folder, stored
> by a path specified in $TMPDIR environment variable.
>
> Check was done by calling Lua returned_path:find(tmpdir_path).
> If tmpdir path contained 'special' characters such as '.', it
> didn't match, because string.find() takes a regular expression,
> not just a string.
>
> string.startswith() works fine.
>
> Follow-up #4794
> ---
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4794-follow-up-test
> Issue: https://github.com/tarantool/tarantool/issues/4794
I've checked your patch into master as obvious.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-03-06 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 21:15 Vladislav Shpilevoy
2020-03-06 15:45 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306154503.mjz5f47p3jyrb3v5@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] test: fix fio.test.lua flakiness' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox