From: Nikita Pettik <korablev@tarantool.org>
To: Maria Khaydich <maria.khaydich@tarantool.org>
Cc: tarantool-patches <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] box: sql prepare and execute statistics should be reflected in box.stat()
Date: Fri, 6 Mar 2020 14:32:15 +0000 [thread overview]
Message-ID: <20200306143214.GD12214@tarantool.org> (raw)
In-Reply-To: <1583494456.594178474@f380.i.mail.ru>
On 06 Mar 14:34, Maria Khaydich wrote:
>
> Thank you for the review. Fixed the comments:
> ----------------------------------------------------------------------
> The patch fixes a bug for the previous commit when statistics on box.execute
> was collected twice. This happened because sql_prepare_and_execute called
> sql_execute under the hood, so there's no need to do rmean_collect in both
> of them.
>
> Follow-up #4756
> ---
> Issue:
> https://github.com/tarantool/tarantool/issues/4756
> Branch:
> https://github.com/tarantool/tarantool/commit/a9c688b7312c8dc786ea14246eb380f9b5a148cf
LGTM. Pushed to master as obvious.
next prev parent reply other threads:[~2020-03-06 14:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 18:35 Maria Khaydich
2020-02-10 23:06 ` Nikita Pettik
2020-02-13 21:44 ` Vladislav Shpilevoy
2020-02-19 16:37 ` Maria Khaydich
2020-02-19 17:16 ` Nikita Pettik
2020-02-25 11:08 ` Maria Khaydich
2020-02-25 13:02 ` Nikita Pettik
2020-02-25 20:29 ` Vladislav Shpilevoy
2020-02-26 15:50 ` Maria Khaydich
2020-02-27 0:08 ` Vladislav Shpilevoy
2020-02-27 13:21 ` Nikita Pettik
2020-03-03 16:42 ` Maria Khaydich
2020-03-03 22:39 ` Vladislav Shpilevoy
2020-03-06 11:34 ` Maria Khaydich
2020-03-06 14:32 ` Nikita Pettik [this message]
2020-03-06 15:09 ` Nikita Pettik
2020-03-04 13:47 ` Nikita Pettik
2020-02-25 22:26 ` Kirill Yukhin
2020-02-25 23:30 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306143214.GD12214@tarantool.org \
--to=korablev@tarantool.org \
--cc=maria.khaydich@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] box: sql prepare and execute statistics should be reflected in box.stat()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox