From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] box: on cfg properly check memory quota
Date: Thu, 5 Mar 2020 11:41:44 +0000 [thread overview]
Message-ID: <20200305114144.GE9655@tarantool.org> (raw)
In-Reply-To: <cad2416c8386d40becd21848bc037a6403191814.1583366981.git.v.shpilevoy@tarantool.org>
On 05 Mar 01:14, Vladislav Shpilevoy wrote:
> box_check_config() didn't check memtx_memory and vinyl_memory
> upper bound. As a result, it was possible to set memory size
> higher than what the quota allows as maximum.
>
> That worked only when box.cfg() was called first time, because
> quota_init() does not check its value. Subsequent box.cfg() calls
> use quota_set(), which aborts the program if a size is too big.
> Only in debug mode. In release quota_set() also worked with any
> sizes.
>
> Closes #4705
> ---
LGTM.
next prev parent reply other threads:[~2020-03-05 11:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 0:14 [Tarantool-patches] [PATCH 0/2] box.cfg() check memtx/vinyl_memory Vladislav Shpilevoy
2020-03-05 0:14 ` [Tarantool-patches] [PATCH 1/2] box: fail in box_check_config() on bad sql cache size Vladislav Shpilevoy
2020-03-05 11:35 ` Nikita Pettik
2020-03-05 20:53 ` Vladislav Shpilevoy
2020-03-05 21:00 ` Nikita Pettik
2020-03-05 21:17 ` Vladislav Shpilevoy
2020-03-19 15:27 ` Igor Munkin
2020-03-20 0:11 ` Vladislav Shpilevoy
2020-03-05 0:14 ` [Tarantool-patches] [PATCH 2/2] box: on cfg properly check memory quota Vladislav Shpilevoy
2020-03-05 11:41 ` Nikita Pettik [this message]
2020-03-20 13:56 ` [Tarantool-patches] [PATCH 0/2] box.cfg() check memtx/vinyl_memory Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305114144.GE9655@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] box: on cfg properly check memory quota' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox