From: Nikita Pettik <korablev@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] iproto: add an empty body to the unprepare response
Date: Thu, 5 Mar 2020 08:41:35 +0000 [thread overview]
Message-ID: <20200305084135.GC9655@tarantool.org> (raw)
In-Reply-To: <20200305054101.6btvhiglj6olbijv@tarantool.org>
On 05 Mar 08:41, Kirill Yukhin wrote:
> Hello,
>
> On 03 мар 19:16, Chris Sosnin wrote:
> > Absence of the body in the unprepare response forces users to perform
> > additional checks to avoid errors. Adding an empty body fixes this problem.
> >
> > Closes #4769
> > ---
> > branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4769-unprepare-response-body
> > issue: https://github.com/tarantool/tarantool/issues/4769
> >
> > As Nikita suggested, I created box/iproto.test.lua, and basically
> > inserted wrappers for requests testing from box-py for future usage.
>
> Could you please rename the test to be not so generic?
> Like box/gh-4769-iproto-unprep-body or whatever.
Kirill, this test is going to assemble all iproto-related tests
which don't rely on net.box module. Setting up all preparations
required for raw iproto communication results in duplicating ~30-40
lines of code in each test file.
> --
> Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-03-05 8:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 16:16 Chris Sosnin
2020-03-03 22:33 ` Vladislav Shpilevoy
2020-03-04 8:14 ` Chris Sosnin
2020-03-04 22:39 ` Vladislav Shpilevoy
2020-03-05 5:41 ` Kirill Yukhin
2020-03-05 8:41 ` Nikita Pettik [this message]
2020-03-06 17:27 ` Alexander Turenko
2020-03-06 19:58 ` Chris Sosnin
2020-03-06 20:39 ` Alexander Turenko
2020-03-07 22:02 ` Nikita Pettik
2020-03-08 17:13 ` Alexander Turenko
2020-03-15 15:34 ` Vladislav Shpilevoy
2020-03-17 8:04 ` Kirill Yukhin
2020-03-16 20:33 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305084135.GC9655@tarantool.org \
--to=korablev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] iproto: add an empty body to the unprepare response' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox