From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/3] Add ability to drop constraints
Date: Thu, 5 Mar 2020 09:32:31 +0300 [thread overview]
Message-ID: <20200305063231.p4w6as3hkgcqfio5@tarantool.org> (raw)
In-Reply-To: <41e6f2fd-304d-af32-d13f-5ce83fb56570@tarantool.org>
Hello,
On 03 мар 23:13, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patchset!
>
> On 03/03/2020 11:12, Roman Khabibov wrote:
> > @ChangeLog
> > - Add ability to drop any table constraint with
> > <ALTER TABLE ... DROP CONSTRAINT ...>.
> > - Display table name in "no such constraint" error message.
>
> Almost ok. But template is different:
>
> @ChangeLog
> - Text description,
> probably multiline (gh-####).
And please, no line breaks.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-03-05 6:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 10:12 Roman Khabibov
2020-03-03 10:12 ` [Tarantool-patches] [PATCH v2 1/3] sql: improve "no such constraint" error message Roman Khabibov
2020-03-03 10:12 ` [Tarantool-patches] [PATCH v2 2/3] sql: don't select from _index during parsing Roman Khabibov
2020-03-03 12:47 ` Roman Khabibov
2020-03-03 10:12 ` [Tarantool-patches] [PATCH v2 3/3] sql: support constraint drop Roman Khabibov
2020-03-03 22:13 ` [Tarantool-patches] [PATCH v2 0/3] Add ability to drop constraints Vladislav Shpilevoy
2020-03-05 6:32 ` Kirill Yukhin [this message]
2020-03-04 21:09 ` Nikita Pettik
-- strict thread matches above, loose matches on Subject: below --
2020-02-29 12:46 Roman Khabibov
2020-02-29 15:31 ` Vladislav Shpilevoy
2020-03-02 12:11 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305063231.p4w6as3hkgcqfio5@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/3] Add ability to drop constraints' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox