Re: [Tarantool-patches] [PATCH] build: disable LUAJIT_ENABLE_PAIRSMM

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 20 фев 18:20, Igor Munkin wrote:
> Since this build flag has been removed as a result of reverting the
> tarantool/luajit@d4e985a, its definition in the corresponding Tarantool
> cmake file is irrelevant.
> 
> Furthermore, considering the breakage faced in #4770 the following tests
> are introduced:
> * the check whether space __pairs metamethod is set to space.pairs to
>   create a Lua Fun iterator that handles __pairs manually underneath.
> * the check whether pairs builtin behaviour doesn't change when __pairs
>   is set e.g. on space object.
> 
> Follow-up #4560
> Closes #4770
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
> 
> Issue: https://github.com/tarantool/tarantool/issues/4770
> Branch: https://github.com/tarantool/tarantool/tree/imun/gh-4770-broken-pairs
> 
> @ChangeLog (need to be added to already released versions):
> | The feature is removed since we faced the issues with the backward
> | compatibility between Lua 5.1 and Lua 5.2 within Tarantool modules as
> | well as other third party code (see #4770).
> 
>  cmake/luajit.cmake     |  1 -
>  test/box/misc.result   | 40 ++++++++++++++++++++++++++++++++++++++++
>  test/box/misc.test.lua | 15 +++++++++++++++

Could you please extract the test into separate file?

--
Regards, Kirill Yukhin