From: Nikita Pettik <korablev@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/3] Add ability to drop constraints
Date: Wed, 4 Mar 2020 21:09:46 +0000 [thread overview]
Message-ID: <20200304210946.GA9655@tarantool.org> (raw)
In-Reply-To: <20200303101204.16338-1-roman.habibov@tarantool.org>
On 03 Mar 13:12, Roman Khabibov wrote:
> @ChangeLog
> - Add ability to drop any table constraint with
> <ALTER TABLE ... DROP CONSTRAINT ...>.
> - Display table name in "no such constraint" error message.
Pushed to master, updated changelog. Thanks.
> Roman Khabibov (3):
> sql: improve "no such constraint" error message
> sql: don't select from _index during parsing
> sql: support constraint drop
>
> src/box/constraint_id.h | 1 +
> src/box/errcode.h | 2 +-
> src/box/space.h | 15 ++++
> src/box/sql/alter.c | 2 +-
> src/box/sql/build.c | 145 ++++++++++++++++++++++-------------
> src/box/sql/parse.y | 4 +-
> src/box/sql/parse_def.h | 11 +--
> src/box/sql/pragma.c | 8 +-
> src/box/sql/sqlInt.h | 7 +-
> src/box/sql/vdbe.c | 10 ++-
> test/sql-tap/alter2.test.lua | 2 +-
> test/sql/checks.result | 2 +-
> test/sql/constraint.result | 81 +++++++++++++++++++
> test/sql/constraint.test.lua | 28 +++++++
> 14 files changed, 241 insertions(+), 77 deletions(-)
>
> --
> 2.21.0 (Apple Git-122)
>
next prev parent reply other threads:[~2020-03-04 21:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 10:12 Roman Khabibov
2020-03-03 10:12 ` [Tarantool-patches] [PATCH v2 1/3] sql: improve "no such constraint" error message Roman Khabibov
2020-03-03 10:12 ` [Tarantool-patches] [PATCH v2 2/3] sql: don't select from _index during parsing Roman Khabibov
2020-03-03 12:47 ` Roman Khabibov
2020-03-03 10:12 ` [Tarantool-patches] [PATCH v2 3/3] sql: support constraint drop Roman Khabibov
2020-03-03 22:13 ` [Tarantool-patches] [PATCH v2 0/3] Add ability to drop constraints Vladislav Shpilevoy
2020-03-05 6:32 ` Kirill Yukhin
2020-03-04 21:09 ` Nikita Pettik [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-29 12:46 Roman Khabibov
2020-02-29 15:31 ` Vladislav Shpilevoy
2020-03-02 12:11 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304210946.GA9655@tarantool.org \
--to=korablev@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/3] Add ability to drop constraints' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox