From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] build: link bundled libcurl with c-ares
Date: Wed, 4 Mar 2020 15:42:53 +0300 [thread overview]
Message-ID: <20200304124253.e2yjhmw5lj2drxay@tkn_work_nb> (raw)
In-Reply-To: <94B97C48-7273-418B-B404-CC714348254A@tarantool.org>
On Tue, Mar 03, 2020 at 07:46:48PM +0300, Serge Petrenko wrote:
> Hi! Thanks for the review! I fixed your comments and performed the actions you expected me
> to perform, except one. More info inline. The diff is below.
This patch LGTM. CCed Kirill.
next prev parent reply other threads:[~2020-03-04 12:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 11:54 [Tarantool-patches] [PATCH v2 0/2] build: link curl " Serge Petrenko
2020-01-21 11:54 ` [Tarantool-patches] [PATCH v2 1/2] build: link bundled libcurl " Serge Petrenko
2020-02-08 19:42 ` Alexander Turenko
2020-03-03 16:46 ` Serge Petrenko
2020-03-03 16:51 ` Serge Petrenko
2020-03-03 23:20 ` Alexander Turenko
2020-03-04 12:42 ` Alexander Turenko [this message]
2020-03-05 5:27 ` Kirill Yukhin
2020-01-21 11:54 ` [Tarantool-patches] [PATCH v2 2/2] build: add bundled curl and c-ares to version output Serge Petrenko
2020-03-04 12:03 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304124253.e2yjhmw5lj2drxay@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] build: link bundled libcurl with c-ares' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox