From: Igor Munkin <imun@tarantool.org> To: Sergey Ostanevich <sergos@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Make string to number conversions fail on NUL char Date: Tue, 3 Mar 2020 20:36:22 +0300 [thread overview] Message-ID: <20200303173622.GZ404@tarantool.org> (raw) In-Reply-To: <62003dc4b5a3672d02c3ec599b5ecb65a557d6b5.1581635592.git.imun@tarantool.org> Kirill, We discussed offline with Sasha and his review looks to be excess considering Sergos' ack and the patch presence in upstream. Please proceed. On 14.02.20, Igor Munkin wrote: > The routine used for conversion a string representation to number > (lj_strscan_scan) doesn't respect the size of the given string/buffer. > Such behaviour leads to the following results: > > | local a = tonumber("inf\x00imun") -- the result is 'inf' > | local b = tonumber("\x36\x00\x80") -- the result is 6 > > The behaviour described above is similar to the one vanila Lua 5.1 has: > > | $ ./lua -e 'print(_VERSION, tonumber("inf"..string.char(0).."imun"))' > | Lua 5.1 inf > > However, the issue is fixed in Lua 5.2 and the results are the following: > | $ ./lua -e 'print(_VERSION, tonumber("inf"..string.char(0).."imun"))' > | Lua 5.2 nil > > The patch introduces additional parameter to lj_strscan_scan routine to > detect whether there is nothing left after the null character. > > Relates to tarantool#4773 > > Reported-by: Alexander Turenko <alexander.turenko@tarantool.org> Added Sergos' ack, force-pushed to the branch. > Signed-off-by: Igor Munkin <imun@tarantool.org> > --- > > This is a backport of the origin commit from v2.1 branch in LuaJIT > repo extended with tests and commit message. Commit subject is left > unchanged with the respect to the origin commit. > > Upstream commit: https://github.com/LuaJIT/LuaJIT/commit/0ad60ccbc3768fa8e3e726858adf261950edbc22 > Issue: https://github.com/tarantool/tarantool/issues/4773 > Branch: https://github.com/tarantool/luajit/tree/imun/tonumber-fail-on-NUL-char > > src/lj_cparse.c | 3 ++- > src/lj_lex.c | 2 +- > src/lj_strscan.c | 11 +++++---- > src/lj_strscan.h | 3 ++- > ...gh-4773-tonumber-fail-on-NUL-char.test.lua | 24 +++++++++++++++++++ > 5 files changed, 36 insertions(+), 7 deletions(-) > create mode 100755 test/gh-4773-tonumber-fail-on-NUL-char.test.lua > <snipped> > -- > 2.25.0 > -- Best regards, IM
next prev parent reply other threads:[~2020-03-03 17:41 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-13 23:57 Igor Munkin 2020-02-14 0:07 ` Igor Munkin 2020-03-03 14:53 ` Sergey Ostanevich 2020-03-03 17:36 ` Igor Munkin [this message] 2020-03-05 7:49 ` Kirill Yukhin 2020-03-05 9:36 ` Igor Munkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200303173622.GZ404@tarantool.org \ --to=imun@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=sergos@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] Make string to number conversions fail on NUL char' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox