From: Kirill Yukhin <kyukhin@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: kirichenkoga@gmail.com, tarantool-patches@dev.tarantool.org,
v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] replication: fix rebootstrap in case the instance is listed in box.cfg.replication
Date: Tue, 3 Mar 2020 11:25:43 +0300 [thread overview]
Message-ID: <20200303082543.cxzoeyriccwi6q35@tarantool.org> (raw)
In-Reply-To: <20200228170130.81713-1-sergepetrenko@tarantool.org>
Hello,
On 28 фев 20:01, Serge Petrenko wrote:
> When checking wheter rejoin is needed, replica loops through all the
> instances in box.cfg.replication, which makes it believe that there is a
> master holding files, needed by it, since it accounts itself just like
> all other instances.
> So make replica skip itself when finding an instance which holds files
> needed by it, and determining whether rebootstrap is needed.
>
> We already have a working test for the issue, it missed the issue due to
> replica.lua replication settings. Fix replica.lua to optionally include
> itself in box.cfg.replication, so that the corresponding test works
> correctly.
>
> Closes #4759
> ---
> https://github.com/tarantool/tarantool/issues/4759
> https://github.com/tarantool/tarantool/tree/sp/gh-4759-rebootstrap-fix
THe patch LGTM. I've checked it into 2.2, 2.3 and master.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-03-03 8:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 17:01 Serge Petrenko
2020-02-28 23:43 ` Vladislav Shpilevoy
2020-02-29 8:54 ` Konstantin Osipov
2020-02-29 9:52 ` Serge Petrenko
2020-02-29 14:19 ` Vladislav Shpilevoy
2020-03-02 17:18 ` Serge Petrenko
2020-03-02 21:26 ` Vladislav Shpilevoy
2020-03-03 8:25 ` Kirill Yukhin [this message]
2020-03-05 4:52 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303082543.cxzoeyriccwi6q35@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=kirichenkoga@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] replication: fix rebootstrap in case the instance is listed in box.cfg.replication' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox