From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Subject: [Tarantool-patches] [PATCH 4/7] popen: log errors if popen creation failed Date: Mon, 2 Mar 2020 23:12:24 +0300 [thread overview] Message-ID: <20200302201227.31785-5-gorcunov@gmail.com> (raw) In-Reply-To: <20200302201227.31785-1-gorcunov@gmail.com> On error path we arm diag with error but strictly speaking some users (such as unit tests) do not have to access diag for logging. Thus log it explicitly for debug sake. Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/lib/core/popen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/core/popen.c b/src/lib/core/popen.c index ce7d7fff7..806d004bf 100644 --- a/src/lib/core/popen.c +++ b/src/lib/core/popen.c @@ -948,6 +948,7 @@ popen_new(struct popen_opts *opts) return handle; out_err: + diag_log(); saved_errno = errno; popen_delete(handle); for (i = 0; i < lengthof(pfd); i++) { -- 2.20.1
next prev parent reply other threads:[~2020-03-02 20:13 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-02 20:12 [Tarantool-patches] [PATCH 0/7] popen: various fixes and a test Cyrill Gorcunov 2020-03-02 20:12 ` [Tarantool-patches] [PATCH 1/7] core/say: Export logger fd Cyrill Gorcunov 2020-03-02 20:12 ` [Tarantool-patches] [PATCH 2/7] popen: allow accessing environ variable Cyrill Gorcunov 2020-03-02 20:12 ` [Tarantool-patches] [PATCH 3/7] popen: close_inherited_fds - add support for macos/freebsd Cyrill Gorcunov 2020-03-02 20:12 ` Cyrill Gorcunov [this message] 2020-03-02 20:12 ` [Tarantool-patches] [PATCH 5/7] popen: add logging in child process Cyrill Gorcunov 2020-03-02 20:12 ` [Tarantool-patches] [PATCH 6/7] popen: handle setsid os specifics Cyrill Gorcunov 2020-03-03 11:38 ` Alexander Turenko 2020-03-03 11:45 ` Cyrill Gorcunov 2020-03-10 15:49 ` Alexander Turenko 2020-03-10 16:36 ` Alexander Turenko 2020-03-10 16:41 ` Cyrill Gorcunov 2020-03-10 17:12 ` Alexander Turenko 2020-03-10 17:40 ` Cyrill Gorcunov 2020-03-11 7:55 ` [Tarantool-patches] [PATCH v5 6/7] popen: handle sid on macos Cyrill Gorcunov 2020-03-06 14:30 ` [Tarantool-patches] [PATCH v2 6/7] popen: handle setsid os specifics Cyrill Gorcunov 2020-03-10 8:02 ` [Tarantool-patches] [PATCH v3 6/7] popen: use ioctl on macos Cyrill Gorcunov 2020-03-02 20:12 ` [Tarantool-patches] [PATCH 7/7] test/unit: add popen test Cyrill Gorcunov 2020-03-11 20:22 ` Alexander Turenko 2020-03-12 10:38 ` [Tarantool-patches] [PATCH v5 " Cyrill Gorcunov 2020-03-12 11:58 ` [Tarantool-patches] [PATCH 0/7] popen: various fixes and a test Alexander Turenko 2020-03-12 12:18 ` Cyrill Gorcunov 2020-03-16 15:58 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200302201227.31785-5-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 4/7] popen: log errors if popen creation failed' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox