Re: [Tarantool-patches] [PATCH v5 0/4] replication: fix applying of rows originating from local instance

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 28 фев 11:34, Serge Petrenko wrote:
> https://github.com/tarantool/tarantool/issues/4739
> https://github.com/tarantool/tarantool/tree/sp/gh-4739-vclock-assert-v4
> 
> @ChangeLog
>  - fix possible vclock ordering violations in
>    master-master replication when one of the
>    masters restarts (gh-4739)
> 
> Changes in v5:
>  - review fixes as per reviews from Vlad and Kostja
>  - added a test
>  - applied Vlads test amendments
>  - added a changelog
> 
> Changes in v4:
>  - move row skipping logic from recovery to relay
>  - encode a list of instances whose rows to skip
>    in SUBSCRIBE request insead of encoding
>    is_orhpan status
> 
> Changes in v3:
>  - review fixes as per review from Vlad
>  - instead of skipping rows on replica side,
>    do it on master side, by patching recovery
>    to silently follow rows coming from a certain
>    instance.
> 
> Changes in v2:
> - review fixes as per review from Kostja
> 
> Serge Petrenko (4):
>   box: expose box_is_orphan method
>   wal: warn when trying to write a record with a broken lsn
>   replication: implement an instance id filter for relay
>   replication: do not relay rows coming from a remote instance back to
>     it

I've checked your patchset into 2.2, 2.3 and master.

--
Regards, Kirill Yukhin