Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH vshard 1/1] router: bucket_id_strcrc32 and bucket_id_mpcrc32
Date: Sun, 1 Mar 2020 19:52:28 +0300	[thread overview]
Message-ID: <20200301165228.GB25151@atlas> (raw)
In-Reply-To: <e21fb74c-3040-a165-4952-371f5f8839ad@tarantool.org>

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [20/02/29 20:14]:
> On 27/02/2020 07:53, Konstantin Osipov wrote:
> > * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [20/02/27 09:42]:
> >>> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [20/02/26 09:31]:
> >>>> Closes #207
> >>>
> >>> While you're at it, is this hardware crc32?
> >>
> >> Yes, this is hardware, when possible. And it is in C. See crc32.c
> >> files (there are two of them).
> > 
> >  I mean the entire method could be in C, including building a
> >  msgpack string from cdata.
> 
> But how building MessagePack is related to crc32? We will need to
> do that in C anyway. Now I am doing that via msgpackffi, which is
> fast enough.

Calling msgpackffi from Lua is slow unless the method is JITed. 

Most of the overhead is coming from invoking functions, not from
what they do.

If you had a single Lua-C function which would take all arguments
from Lua stack and return crc32 it may be faster.


-- 
Konstantin Osipov, Moscow, Russia
https://scylladb.com

      reply	other threads:[~2020-03-01 16:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 23:52 Vladislav Shpilevoy
2020-02-26  7:15 ` Oleg Babin
2020-02-27  0:22   ` Vladislav Shpilevoy
2020-02-27 10:12     ` Oleg Babin
2020-02-29 17:09   ` Vladislav Shpilevoy
2020-03-02  8:10     ` Oleg Babin
2020-03-02 21:06       ` Vladislav Shpilevoy
2020-02-26  8:20 ` Konstantin Osipov
2020-02-27  0:25   ` Vladislav Shpilevoy
2020-02-27  6:53     ` Konstantin Osipov
2020-02-29 17:10       ` Vladislav Shpilevoy
2020-03-01 16:52         ` Konstantin Osipov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200301165228.GB25151@atlas \
    --to=kostja.osipov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH vshard 1/1] router: bucket_id_strcrc32 and bucket_id_mpcrc32' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox