From: Roman Khabibov <roman.habibov@tarantool.org> To: v.shpilevoy@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v2 0/3] Add ability to drop constraints Date: Sat, 29 Feb 2020 15:46:43 +0300 [thread overview] Message-ID: <20200229124645.67971-1-roman.habibov@tarantool.org> (raw) @ChangeLog - Add function space_index_by_name(). - Add ability to spacify searching index in OP_SDelete. - Add function vdbe_emit_index_drop() to drop index by name. - Remove box_index_by_name() from build.c and pragma.c. - Rewrite function sql_drop_foreign_key() to sql_drop_constraint(). - Add ability to drop all the types of constraints. - Modify "no such constrait" error message. Hello, everybody! As Nikita requested, I performed the patch to remove box_index_by_name() from build.c and pragma.c, but what about analyze.c? Still had to add space_index_by_name() to use in pragma.c, beacuse struct index is required. Roman Khabibov (3): sql: improve "no such constraint" error message sql: don't select from _index during parsing sql: support constraint drop src/box/constraint_id.h | 1 + src/box/errcode.h | 2 +- src/box/space.h | 15 ++++ src/box/sql/alter.c | 2 +- src/box/sql/build.c | 143 ++++++++++++++++++++++------------- src/box/sql/parse.y | 4 +- src/box/sql/parse_def.h | 11 +-- src/box/sql/pragma.c | 8 +- src/box/sql/sqlInt.h | 7 +- src/box/sql/vdbe.c | 10 ++- test/sql-tap/alter2.test.lua | 2 +- test/sql/checks.result | 2 +- test/sql/constraint.result | 81 ++++++++++++++++++++ test/sql/constraint.test.lua | 28 +++++++ 14 files changed, 240 insertions(+), 76 deletions(-) -- 2.21.0 (Apple Git-122)
next reply other threads:[~2020-02-29 12:46 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-29 12:46 Roman Khabibov [this message] 2020-02-29 12:46 ` [Tarantool-patches] [PATCH v2 1/3] sql: improve "no such constraint" error message Roman Khabibov 2020-02-29 15:31 ` Vladislav Shpilevoy 2020-03-03 10:15 ` Roman Khabibov 2020-02-29 12:46 ` [Tarantool-patches] [PATCH v2 2/3] sql: don't select from _index during parsing Roman Khabibov 2020-02-29 15:31 ` Vladislav Shpilevoy 2020-03-03 10:15 ` Roman Khabibov 2020-02-29 15:31 ` [Tarantool-patches] [PATCH v2 0/3] Add ability to drop constraints Vladislav Shpilevoy 2020-03-02 12:11 ` Nikita Pettik 2020-03-03 10:12 Roman Khabibov 2020-03-03 22:13 ` Vladislav Shpilevoy 2020-03-05 6:32 ` Kirill Yukhin 2020-03-04 21:09 ` Nikita Pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200229124645.67971-1-roman.habibov@tarantool.org \ --to=roman.habibov@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 0/3] Add ability to drop constraints' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox