From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] popen: fixes to make master branch happy
Date: Fri, 28 Feb 2020 14:42:55 +0300 [thread overview]
Message-ID: <20200228114255.owvdxex2c67r7ogx@tkn_work_nb> (raw)
In-Reply-To: <20200228094815.13826-1-gorcunov@gmail.com>
Pushed to master, but disabled the test rather than remove it.
WBR, Alexander Turenko.
On Fri, Feb 28, 2020 at 12:48:13PM +0300, Cyrill Gorcunov wrote:
> The rule of thumb is to keep master branch in good shape so that
> it will be used to verify own work on top. The popen test cause
> some problems which I have to rework thus just revert it.
>
> Also fix popen build on non linux machines.
>
> branch gorcunov/gh-4031-popen-fixes-2
>
> Cyrill Gorcunov (2):
> popen: fix empty envp type for nonlinux builds
> Revert "test: unit/popen"
>
> src/lib/core/popen.c | 2 +-
> test/unit/CMakeLists.txt | 3 -
> test/unit/popen.c | 253 ---------------------------------------
> test/unit/popen.result | 28 -----
> 4 files changed, 1 insertion(+), 285 deletions(-)
> delete mode 100644 test/unit/popen.c
> delete mode 100644 test/unit/popen.result
>
>
> base-commit: 40a516477aa337b3d15184f99bb1ec1a3095d60a
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-02-28 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 9:48 Cyrill Gorcunov
2020-02-28 9:48 ` [Tarantool-patches] [PATCH 1/2] popen: fix empty envp type for nonlinux builds Cyrill Gorcunov
2020-02-28 9:48 ` [Tarantool-patches] [PATCH 2/2] Revert "test: unit/popen" Cyrill Gorcunov
2020-02-28 11:42 ` Alexander Turenko [this message]
2020-02-28 11:55 ` [Tarantool-patches] [PATCH 0/2] popen: fixes to make master branch happy Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228114255.owvdxex2c67r7ogx@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] popen: fixes to make master branch happy' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox