From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 3/3] box/txn: clear fiber storage right before journal_write
Date: Thu, 27 Feb 2020 23:20:31 +0300 [thread overview]
Message-ID: <20200227202031.GG2464@uranus> (raw)
In-Reply-To: <20200227194729.jposbdcfrskvtqz2@tarantool.org>
On Thu, Feb 27, 2020 at 10:47:29PM +0300, Kirill Yukhin wrote:
> Hello,
>
> // This is not an official review. Just a nitpicking.
>
> > +space:insert{1}
> > +---
> > +- error: Failed to allocate 0 bytes in region for journal_entry
>
> Why 0? How could we ever fail to allocate 0 bytes?
To make this message immutable even if size of the journal_entry
structure get changed. We don't care about the size here but rather
the fact that allocation failed. If you prefer I can put some
randomn number here instead.
next prev parent reply other threads:[~2020-02-27 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 14:16 [Tarantool-patches] [PATCH 0/3] box/txn: fix assert in txn_rollback Cyrill Gorcunov
2020-02-27 14:16 ` [Tarantool-patches] [PATCH 1/3] box/txn: rename txn_write to txn_commit_async Cyrill Gorcunov
2020-02-27 14:16 ` [Tarantool-patches] [PATCH 2/3] box/txn: log error explicitly in txn_commit Cyrill Gorcunov
2020-02-27 14:16 ` [Tarantool-patches] [PATCH 3/3] box/txn: clear fiber storage right before journal_write Cyrill Gorcunov
2020-02-27 19:47 ` Kirill Yukhin
2020-02-27 20:20 ` Cyrill Gorcunov [this message]
2020-02-27 20:27 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227202031.GG2464@uranus \
--to=gorcunov@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 3/3] box/txn: clear fiber storage right before journal_write' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox