Re: [Tarantool-patches] [PATCH] box: user.grant error should be versatile

[Igor Munkin <imun@tarantool.org>]

Masha,

Thanks, the patch LGTM, but I left a few nits below.

On 26.02.20, Maria Khaydich wrote:
> 
> Looks like this patch caused some tests to fail according to Sasha (avtikhon).
> I made another commit fixing the issue.
>  
> ----------------------------------------------------------------------
> Previous commit that was merged into master did not do
> proper clean-up. That caused occasional failures of other
> tests, all with the same error saying user 'guest' already
> had access on universe.

I propose the following rewording for the commit message:
| box: use non-default user for tests
|
| The commit e8009f4158fc2d6efa2824cd634564b3c7a2f899
| ('box: user.grant error should be versatile') introduced a flaky test,
| since it provides a non-default grants for the default 'guest' user
| and doesn't drop the changes at the end.
| To avoid flaky failures a new user is created for the test and dropped
| when the related tests are finished.
Feel free to change it on your own.

>  
> Closes #714

I guess Follow-up #714 is more appropriate here.

> ---
> Branch:
> https://github.com/tarantool/tarantool/compare/eljashm/gh-714-box-schema-user-grant-invalid-error  
> 
>  test/box/access.result   | 18 ++++++++++++------
>  test/box/access.test.lua | 10 ++++++----
>  2 files changed, 18 insertions(+), 10 deletions(-)

<snipped>

>  
> --
> Maria Khaydich
>  
>  

-- 
Best regards,
IM