From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@dev.tarantool.org>
Subject: [Tarantool-patches] [PATCH 2/3] box/txn: log error explicitly in txn_commit
Date: Thu, 27 Feb 2020 17:16:27 +0300 [thread overview]
Message-ID: <20200227141628.13782-3-gorcunov@gmail.com> (raw)
In-Reply-To: <20200227141628.13782-1-gorcunov@gmail.com>
To be on same way as we do in txn_write_to_wal.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
src/box/txn.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/box/txn.c b/src/box/txn.c
index cac97d1eb..9e2888c09 100644
--- a/src/box/txn.c
+++ b/src/box/txn.c
@@ -604,8 +604,10 @@ txn_commit(struct txn *txn)
fiber_set_cancellable(cancellable);
}
int res = txn->signature >= 0 ? 0 : -1;
- if (res != 0)
+ if (res != 0) {
diag_set(ClientError, ER_WAL_IO);
+ diag_log();
+ }
/* Synchronous transactions are freed by the calling fiber. */
txn_free(txn);
--
2.20.1
next prev parent reply other threads:[~2020-02-27 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 14:16 [Tarantool-patches] [PATCH 0/3] box/txn: fix assert in txn_rollback Cyrill Gorcunov
2020-02-27 14:16 ` [Tarantool-patches] [PATCH 1/3] box/txn: rename txn_write to txn_commit_async Cyrill Gorcunov
2020-02-27 14:16 ` Cyrill Gorcunov [this message]
2020-02-27 14:16 ` [Tarantool-patches] [PATCH 3/3] box/txn: clear fiber storage right before journal_write Cyrill Gorcunov
2020-02-27 19:47 ` Kirill Yukhin
2020-02-27 20:20 ` Cyrill Gorcunov
2020-02-27 20:27 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227141628.13782-3-gorcunov@gmail.com \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/3] box/txn: log error explicitly in txn_commit' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox