From: Kirill Yukhin <kyukhin@tarantool.org>
To: Maria Khaydich <maria.khaydich@tarantool.org>
Cc: tarantool-patches <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] box: sql prepare and execute statistics should be reflected in box.stat()
Date: Wed, 26 Feb 2020 01:26:09 +0300 [thread overview]
Message-ID: <20200225222609.ve6gnec6wirieobk@tarantool.org> (raw)
In-Reply-To: <1581359737.397395198@f221.i.mail.ru>
Hello,
On 10 фев 21:35, Maria Khaydich wrote:
>
> Calling prepare and execute did not update corresponding request statistics
> in the box.stat table. This happened because methods that collect stats were
> never called where they should have been.
>
> Closes #4756
>
> ---
> Issue:
> https://github.com/tarantool/tarantool/issues/4756
> Branch:
> https://github.com/tarantool/tarantool/compare/eljashm/gh-4756-box-stat-execute-and-prepare-not-updated
I've checked your patch into 2.3 and master.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-02-25 22:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 18:35 Maria Khaydich
2020-02-10 23:06 ` Nikita Pettik
2020-02-13 21:44 ` Vladislav Shpilevoy
2020-02-19 16:37 ` Maria Khaydich
2020-02-19 17:16 ` Nikita Pettik
2020-02-25 11:08 ` Maria Khaydich
2020-02-25 13:02 ` Nikita Pettik
2020-02-25 20:29 ` Vladislav Shpilevoy
2020-02-26 15:50 ` Maria Khaydich
2020-02-27 0:08 ` Vladislav Shpilevoy
2020-02-27 13:21 ` Nikita Pettik
2020-03-03 16:42 ` Maria Khaydich
2020-03-03 22:39 ` Vladislav Shpilevoy
2020-03-06 11:34 ` Maria Khaydich
2020-03-06 14:32 ` Nikita Pettik
2020-03-06 15:09 ` Nikita Pettik
2020-03-04 13:47 ` Nikita Pettik
2020-02-25 22:26 ` Kirill Yukhin [this message]
2020-02-25 23:30 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225222609.ve6gnec6wirieobk@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=maria.khaydich@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] box: sql prepare and execute statistics should be reflected in box.stat()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox