From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/3] Fix upgrade from 2.1 sequence
Date: Mon, 24 Feb 2020 22:48:26 +0300 [thread overview]
Message-ID: <20200224194826.hi3pfgqk45vtst3i@tarantool.org> (raw)
In-Reply-To: <cover.1581972845.git.v.shpilevoy@tarantool.org>
Hello,
On 17 фев 21:57, Vladislav Shpilevoy wrote:
> The patchset fixes inability to upgrade from 2.1 if there is an
> automatically generated sequence. The problem was that upgrade
> tried to update a tuple in _space_sequence in-place, calling
> space:update() method. But it was not properly supported for
> _space_sequence. The patchset turns it into delete + insert, and
> bans updates for this space.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4771-2.2-upgrade
> Issue: https://github.com/tarantool/tarantool/issues/4771
I've checked your patch into 2.2, 2.3 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-02-24 19:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 20:57 Vladislav Shpilevoy
2020-02-17 20:57 ` [Tarantool-patches] [PATCH 1/3] upgrade: add missing sys triggers off and erasure Vladislav Shpilevoy
2020-02-21 15:20 ` Nikita Pettik
2020-02-22 16:17 ` Vladislav Shpilevoy
2020-02-17 20:57 ` [Tarantool-patches] [PATCH 2/3] box: forbid to update/replace _space_sequence Vladislav Shpilevoy
2020-02-21 15:29 ` Nikita Pettik
2020-02-22 16:16 ` Vladislav Shpilevoy
2020-02-17 20:57 ` [Tarantool-patches] [PATCH 3/3] upgrade: fix generated sequence upgrade from 2.1 Vladislav Shpilevoy
2020-02-21 15:42 ` Nikita Pettik
2020-02-22 16:16 ` Vladislav Shpilevoy
2020-02-24 19:48 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224194826.hi3pfgqk45vtst3i@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/3] Fix upgrade from 2.1 sequence' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox