From: Kirill Yukhin <kyukhin@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v8 0/2] fiber: Handle stack madvise/mprotect errors
Date: Mon, 24 Feb 2020 22:25:09 +0300 [thread overview]
Message-ID: <20200224192509.pqkq23s6hg7joyxj@tarantool.org> (raw)
In-Reply-To: <20200214132220.29830-1-gorcunov@gmail.com>
Hello,
On 14 фев 16:22, Cyrill Gorcunov wrote:
> in v8:
> - address Vlad's comments
> - include slab stat condition into the test
>
> issue https://github.com/tarantool/tarantool/issues/4722
> branch https://github.com/tarantool/tarantool/tree/gorcunov/gh-4722-mprotect-diag-error-8
I've checked your patchset into 2.2, 2.3 and master.
I hope we'll improve it further.
Still, this is not something critical, so I didn't checked
it into 1.10.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-02-24 19:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 13:22 Cyrill Gorcunov
2020-02-14 13:22 ` [Tarantool-patches] [PATCH v8 1/2] fiber: set diagnostics at madvise/mprotect failure Cyrill Gorcunov
2020-02-20 21:30 ` Vladislav Shpilevoy
2020-02-14 13:22 ` [Tarantool-patches] [PATCH v8 2/2] fiber: leak slab if unable to bring prots back Cyrill Gorcunov
2020-02-14 14:17 ` Konstantin Osipov
2020-02-14 14:22 ` Cyrill Gorcunov
2020-02-14 14:29 ` Konstantin Osipov
2020-02-14 14:31 ` Cyrill Gorcunov
2020-02-20 21:00 ` Alexander Turenko
2020-02-21 7:15 ` Konstantin Osipov
2020-02-24 19:25 ` Kirill Yukhin [this message]
2020-02-24 19:31 ` [Tarantool-patches] [PATCH v8 0/2] fiber: Handle stack madvise/mprotect errors Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224192509.pqkq23s6hg7joyxj@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v8 0/2] fiber: Handle stack madvise/mprotect errors' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox