From: Kirill Yukhin <kyukhin@tarantool.org>
To: Chris Sosnin <k.sosnin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] app: verify unix socket path length in socket.tcp_server()
Date: Mon, 24 Feb 2020 21:18:57 +0300 [thread overview]
Message-ID: <20200224181857.3p5leezuuedt3ucx@tarantool.org> (raw)
In-Reply-To: <20200221123203.6956-1-k.sosnin@tarantool.org>
Hello,
On 21 фев 15:32, Chris Sosnin wrote:
> Providing socket pathname longer than UNIX_PATH_MAX to socket.tcp_server()
> will not cause any error, lbox_socket_local_resolve will just truncate the
> name according to the limit, causing bad behavior (tarantool will try to
> access a socket, which doesn't exist). Thus, let's verify, that pathname
> can fit into buffer.
>
> Closes #4634
> ---
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4634-verify-socket-path-length
> issue: https://github.com/tarantool/tarantool/issues/4634
I've checked your patch into 2.3 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-02-24 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 12:32 Chris Sosnin
2020-02-22 16:28 ` Vladislav Shpilevoy
2020-02-22 16:43 ` Chris Sosnin
2020-02-23 14:58 ` Vladislav Shpilevoy
2020-02-24 18:18 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224181857.3p5leezuuedt3ucx@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=k.sosnin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] app: verify unix socket path length in socket.tcp_server()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox