From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/3] box: forbid to update/replace _space_sequence
Date: Fri, 21 Feb 2020 18:29:34 +0300 [thread overview]
Message-ID: <20200221152934.GD51816@tarantool.org> (raw)
In-Reply-To: <79a6254a868ee44517921a0c89af29d44dd2c4b8.1581972845.git.v.shpilevoy@tarantool.org>
On 17 Feb 21:57, Vladislav Shpilevoy wrote:
> diff --git a/src/box/alter.cc b/src/box/alter.cc
> index 64af71c61..50121c79c 100644
> --- a/src/box/alter.cc
> +++ b/src/box/alter.cc
> @@ -4713,9 +4713,13 @@ on_replace_dd_space_sequence(struct trigger * /* trigger */, void *event)
> return -1;
> }
LGTM
Nit: as always I'd only add brief comment like:
/* UPDATE operation is considered to meaningless for _space_sequence
since ...
*/
> + if ((stmt->new_tuple != NULL) == (stmt->old_tuple != NULL)) {
> + diag_set(ClientError, ER_UNSUPPORTED,
> + "space \"_space_sequence\"", "update");
> + return -1;
> + }
> +
> enum priv_type priv_type = stmt->new_tuple ? PRIV_C : PRIV_D;
> - if (stmt->new_tuple && stmt->old_tuple)
> - priv_type = PRIV_A;
>
> /* Check we have the correct access type on the sequence. * */
> if (is_generated || !stmt->new_tuple) {
next prev parent reply other threads:[~2020-02-21 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 20:57 [Tarantool-patches] [PATCH 0/3] Fix upgrade from 2.1 sequence Vladislav Shpilevoy
2020-02-17 20:57 ` [Tarantool-patches] [PATCH 1/3] upgrade: add missing sys triggers off and erasure Vladislav Shpilevoy
2020-02-21 15:20 ` Nikita Pettik
2020-02-22 16:17 ` Vladislav Shpilevoy
2020-02-17 20:57 ` [Tarantool-patches] [PATCH 2/3] box: forbid to update/replace _space_sequence Vladislav Shpilevoy
2020-02-21 15:29 ` Nikita Pettik [this message]
2020-02-22 16:16 ` Vladislav Shpilevoy
2020-02-17 20:57 ` [Tarantool-patches] [PATCH 3/3] upgrade: fix generated sequence upgrade from 2.1 Vladislav Shpilevoy
2020-02-21 15:42 ` Nikita Pettik
2020-02-22 16:16 ` Vladislav Shpilevoy
2020-02-24 19:48 ` [Tarantool-patches] [PATCH 0/3] Fix upgrade from 2.1 sequence Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221152934.GD51816@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/3] box: forbid to update/replace _space_sequence' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox