From: Nikita Pettik <korablev@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 1/3] upgrade: add missing sys triggers off and erasure Date: Fri, 21 Feb 2020 18:20:23 +0300 [thread overview] Message-ID: <20200221152023.GC51816@tarantool.org> (raw) In-Reply-To: <2637883c072d078cf970a90a9d5b21164380ebd1.1581972845.git.v.shpilevoy@tarantool.org> On 17 Feb 21:57, Vladislav Shpilevoy wrote: LGTM > +local function foreach_system_space(cb) > + local max = box.schema.SYSTEM_ID_MAX > + for id, space in pairs(box.space) do Nit: I'd add brief comment explaining that here we are interested only in 'native' system spaces skipping sysviews etc. > + if type(id) == 'number' and > + (space.engine == 'memtx' or space.engine == 'vinyl') then > + if id > max then > + break > + end > + cb(space) > + end > + end > +end > + > local function set_system_triggers(val) > - box.space._space:run_triggers(val) > - box.space._index:run_triggers(val) > - box.space._user:run_triggers(val) > - box.space._func:run_triggers(val) > - box.space._priv:run_triggers(val) > - box.space._trigger:run_triggers(val) > - box.space._collation:run_triggers(val) > - box.space._schema:run_triggers(val) > - box.space._cluster:run_triggers(val) > - box.space._fk_constraint:run_triggers(val) > - box.space._ck_constraint:run_triggers(val) > + foreach_system_space(function(s) s:run_triggers(val) end) > end >
next prev parent reply other threads:[~2020-02-21 15:20 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-17 20:57 [Tarantool-patches] [PATCH 0/3] Fix upgrade from 2.1 sequence Vladislav Shpilevoy 2020-02-17 20:57 ` [Tarantool-patches] [PATCH 1/3] upgrade: add missing sys triggers off and erasure Vladislav Shpilevoy 2020-02-21 15:20 ` Nikita Pettik [this message] 2020-02-22 16:17 ` Vladislav Shpilevoy 2020-02-17 20:57 ` [Tarantool-patches] [PATCH 2/3] box: forbid to update/replace _space_sequence Vladislav Shpilevoy 2020-02-21 15:29 ` Nikita Pettik 2020-02-22 16:16 ` Vladislav Shpilevoy 2020-02-17 20:57 ` [Tarantool-patches] [PATCH 3/3] upgrade: fix generated sequence upgrade from 2.1 Vladislav Shpilevoy 2020-02-21 15:42 ` Nikita Pettik 2020-02-22 16:16 ` Vladislav Shpilevoy 2020-02-24 19:48 ` [Tarantool-patches] [PATCH 0/3] Fix upgrade from 2.1 sequence Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200221152023.GC51816@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/3] upgrade: add missing sys triggers off and erasure' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox