From: Nikita Pettik <korablev@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 0/4] Don't truncate float in update
Date: Thu, 20 Feb 2020 16:27:27 +0300 [thread overview]
Message-ID: <20200220132727.GF40100@tarantool.org> (raw)
In-Reply-To: <20200220061505.kzbzgcgyjx6b4nkp@tarantool.org>
On 20 Feb 09:15, Kirill Yukhin wrote:
> Hello,
>
> On 04 фев 23:53, Vladislav Shpilevoy wrote:
> > The patchset fixes float value truncation in
> > tuple/space:update/upsert. First commit fixes the actual issue,
> > but introduces another bug that a float value can be stored into a
> > field having double type in its format.
> >
> > The rest 3 commits fix this new bug.
> >
> > However, there is an alternative how these 3 could be done. My
> > solution is that I calculate the result types in
> > xrow_update_*_store() functions. Because of that I don't know the
> > types during xrow_update_*_sizeof(), and it needs to return the
> > maximal possible size instead of exact size. The alternative is to
> > calculate types during sizeof. It would allow to return the exact
> > size. But it also would complicate the code. I can implement this
> > option if it looks better.
> >
> > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4701-update-float-truncate
> > Issue: https://github.com/tarantool/tarantool/issues/4701
>
> LGTM. I've checked your patchset into 2.3 and master.
It seems you forgot to update changelog. Vlad, could you please
paste it here https://github.com/tarantool/tarantool/releases/tag/untagged-2929e826f0a4c08b1c81
> --
> Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-02-20 13:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 22:53 Vladislav Shpilevoy
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 1/4] tuple: don't truncate float in :update() Vladislav Shpilevoy
2020-02-10 14:41 ` Nikita Pettik
2020-02-10 21:18 ` Vladislav Shpilevoy
2020-02-19 21:36 ` Nikita Pettik
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 2/4] tuple: pass tuple format to xrow_update_*_store() Vladislav Shpilevoy
2020-02-10 16:51 ` Nikita Pettik
2020-02-10 21:18 ` Vladislav Shpilevoy
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 3/4] tuple: allow xrow_update sizeof reserve more memory Vladislav Shpilevoy
2020-02-10 16:05 ` Nikita Pettik
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 4/4] tuple: use field type in update of a float/double Vladislav Shpilevoy
2020-02-10 16:16 ` Nikita Pettik
2020-02-10 21:18 ` Vladislav Shpilevoy
2020-02-05 11:09 ` [Tarantool-patches] [PATCH v2 0/4] Don't truncate float in update Konstantin Osipov
2020-02-05 22:11 ` Vladislav Shpilevoy
2020-02-20 6:15 ` Kirill Yukhin
2020-02-20 13:27 ` Nikita Pettik [this message]
2020-02-20 20:30 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220132727.GF40100@tarantool.org \
--to=korablev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/4] Don'\''t truncate float in update' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox