From: Igor Munkin <imun@tarantool.org>
To: olegrok@tarantool.org
Cc: Oleg Babin <babinoleg@mail.ru>,
tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 3/3] tap: is_deeply ignores __pairs metamethod
Date: Thu, 20 Feb 2020 13:57:02 +0300 [thread overview]
Message-ID: <20200220105702.GB404@tarantool.org> (raw)
In-Reply-To: <9330b681273b2789ff147d5769736406695ca23a.1581625524.git.babinoleg@mail.ru>
Oleg,
Thanks for the patch, but since we reverted the corresponding
breakage[1] I guess the changes are irrelevant. Discarding it.
On 13.02.20, olegrok@tarantool.org wrote:
> From: Oleg Babin <babinoleg@mail.ru>
>
> After 1d85144a9b4bbbb026402848efde1ab98bf72633
> is_deeply could use __pairs metamethod when
> iterated through tables. It led to situation
> when two similar tables could be considered
> as different.
> To eliminate such situation default pairs
> was replaced with "pure" pairs that ignores
> __pairs metamethod
>
> Follow-up #4770, #4560
> ---
> src/lua/tap.lua | 9 ++++++---
> test/app-tap/tap.result | 6 ++++--
> test/app-tap/tap.test.lua | 24 +++++++++++++++++++++++-
> 3 files changed, 33 insertions(+), 6 deletions(-)
>
<snipped>
> --
> 2.23.0
>
[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-February/014304.html
--
Best regards,
IM
next prev parent reply other threads:[~2020-02-20 11:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 20:33 [Tarantool-patches] [PATCH 0/3] lua: table fixes olegrok
2020-02-13 20:33 ` [Tarantool-patches] [PATCH 1/3] lua: fix incorrect table.deepcopy __metatable handling olegrok
2020-02-13 22:50 ` Vladislav Shpilevoy
2020-02-20 11:12 ` Igor Munkin
2020-02-13 20:33 ` [Tarantool-patches] [PATCH 2/3] lua: table.deepcopy ignores __pairs metamethod olegrok
2020-02-13 22:50 ` Vladislav Shpilevoy
2020-02-20 11:00 ` Igor Munkin
2020-02-13 20:33 ` [Tarantool-patches] [PATCH 3/3] tap: is_deeply " olegrok
2020-02-13 22:50 ` Vladislav Shpilevoy
2020-02-20 10:57 ` Igor Munkin [this message]
2020-02-13 22:50 ` [Tarantool-patches] [PATCH 0/3] lua: table fixes Vladislav Shpilevoy
2020-02-15 10:05 ` Oleg Babin
2020-02-15 15:35 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220105702.GB404@tarantool.org \
--to=imun@tarantool.org \
--cc=babinoleg@mail.ru \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 3/3] tap: is_deeply ignores __pairs metamethod' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox