From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Subject: [Tarantool-patches] [PATCH 03/14] box/journal: sanitize completion naming Date: Wed, 19 Feb 2020 21:37:02 +0300 [thread overview] Message-ID: <20200219183713.17646-4-gorcunov@gmail.com> (raw) In-Reply-To: <20200219183713.17646-1-gorcunov@gmail.com> Instead of on_done use on_complete prefix since done it too general while we're trying to complete write procedue. Also it is more consistent with txn_complete name. Acked-by: Konstantin Osipov <kostja.osipov@gmail.com> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/box/journal.c | 8 ++++---- src/box/journal.h | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/box/journal.c b/src/box/journal.c index cf6485642..11e78990d 100644 --- a/src/box/journal.c +++ b/src/box/journal.c @@ -54,8 +54,8 @@ struct journal *current_journal = &dummy_journal; struct journal_entry * journal_entry_new(size_t n_rows, struct region *region, - journal_entry_done_cb on_done_cb, - void *on_done_cb_data) + journal_entry_complete_cb on_complete_cb, + void *on_complete_cb_data) { struct journal_entry *entry; @@ -71,8 +71,8 @@ journal_entry_new(size_t n_rows, struct region *region, entry->approx_len = 0; entry->n_rows = n_rows; entry->res = -1; - entry->on_done_cb = on_done_cb; - entry->on_done_cb_data = on_done_cb_data; + entry->on_complete_cb = on_complete_cb; + entry->on_complete_cb_data = on_complete_cb_data; return entry; } diff --git a/src/box/journal.h b/src/box/journal.h index 55900d8e5..64f167c6f 100644 --- a/src/box/journal.h +++ b/src/box/journal.h @@ -43,7 +43,7 @@ struct xrow_header; struct journal_entry; /** Journal entry finalization callback typedef. */ -typedef void (*journal_entry_done_cb)(struct journal_entry *entry, void *data); +typedef void (*journal_entry_complete_cb)(struct journal_entry *entry, void *data); /** * An entry for an abstract journal. @@ -66,11 +66,11 @@ struct journal_entry { * or fail. Entry->res is set to a result value before the callback * is fired. */ - journal_entry_done_cb on_done_cb; + journal_entry_complete_cb on_complete_cb; /** * A journal entry completion callback argument. */ - void *on_done_cb_data; + void *on_complete_cb_data; /** * Approximate size of this request when encoded. */ @@ -94,8 +94,8 @@ struct region; */ struct journal_entry * journal_entry_new(size_t n_rows, struct region *region, - journal_entry_done_cb on_done_cb, - void *on_done_cb_data); + journal_entry_complete_cb on_complete_cb, + void *on_complete_cb_data); /** * Finalize a single entry. @@ -103,7 +103,7 @@ journal_entry_new(size_t n_rows, struct region *region, static inline void journal_entry_complete(struct journal_entry *entry) { - entry->on_done_cb(entry, entry->on_done_cb_data); + entry->on_complete_cb(entry, entry->on_complete_cb_data); } /** -- 2.20.1
next prev parent reply other threads:[~2020-02-19 18:37 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-19 18:36 [Tarantool-patches] [PATCH 00/14] rework async and sync transactions Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 01/14] box/txn: fix void args mess Cyrill Gorcunov 2020-02-20 14:10 ` Nikita Pettik 2020-02-20 14:16 ` Cyrill Gorcunov 2020-02-20 14:34 ` Nikita Pettik 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 02/14] box/journal: use plain int for return value Cyrill Gorcunov 2020-02-20 14:11 ` Nikita Pettik 2020-02-19 18:37 ` Cyrill Gorcunov [this message] 2020-02-20 14:12 ` [Tarantool-patches] [PATCH 03/14] box/journal: sanitize completion naming Nikita Pettik 2020-02-20 14:15 ` Nikita Pettik 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 04/14] box/txn: rename txn_entry_done_cb to txn_entry_complete_cb Cyrill Gorcunov 2020-02-20 14:15 ` Nikita Pettik 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 05/14] box/txn: rename txn_write_to_wal to txn_write_to_wal_async Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 06/14] box/journal: supersede journal_write with journal_write_async Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 07/14] box/txn: rename txn_write to txn_commit_async Cyrill Gorcunov 2020-02-22 20:28 ` Georgy Kirichenko 2020-02-22 21:00 ` Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 08/14] box/txn: move setup of transaction start time to txn_prepare Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 09/14] box/txn: make txn nop processing a separate routine Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 10/14] box/txn: move journal entry allocation into " Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 11/14] box/txn: merge txn_write_to_wal_async to txn_commit_async Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 12/14] box/txn: do not use journal_write_async under the hood Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 13/14] box/journal: introduce journal_write Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 14/14] box/txn: use journal_write in txn_commit Cyrill Gorcunov 2020-02-19 19:09 ` Konstantin Osipov 2020-02-19 20:01 ` Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200219183713.17646-4-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 03/14] box/journal: sanitize completion naming' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox