From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Subject: [Tarantool-patches] [PATCH 14/14] box/txn: use journal_write in txn_commit Date: Wed, 19 Feb 2020 21:37:13 +0300 [thread overview] Message-ID: <20200219183713.17646-15-gorcunov@gmail.com> (raw) In-Reply-To: <20200219183713.17646-1-gorcunov@gmail.com> This allows us to keep wait for transaction complete in one place -- inside journal_write. Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/box/txn.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/src/box/txn.c b/src/box/txn.c index 38241c066..8f9be3269 100644 --- a/src/box/txn.c +++ b/src/box/txn.c @@ -619,25 +619,11 @@ txn_commit(struct txn *txn) return -1; } - /* Send the entry to the journal. */ - if (journal_write_async(req) < 0) { + int res = journal_write(req); + if (res != 0) { diag_set(ClientError, ER_WAL_IO); diag_log(); - return -1; - } - - /* - * In case of non-yielding journal the transaction could already - * be done and there is nothing to wait in such cases. - */ - if (!txn_has_flag(txn, TXN_IS_DONE)) { - bool cancellable = fiber_set_cancellable(false); - fiber_yield(); - fiber_set_cancellable(cancellable); } - int res = txn->signature >= 0 ? 0 : -1; - if (res != 0) - diag_set(ClientError, ER_WAL_IO); /* Synchronous transactions are freed by the calling fiber. */ txn_free(txn); -- 2.20.1
next prev parent reply other threads:[~2020-02-19 18:39 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-19 18:36 [Tarantool-patches] [PATCH 00/14] rework async and sync transactions Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 01/14] box/txn: fix void args mess Cyrill Gorcunov 2020-02-20 14:10 ` Nikita Pettik 2020-02-20 14:16 ` Cyrill Gorcunov 2020-02-20 14:34 ` Nikita Pettik 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 02/14] box/journal: use plain int for return value Cyrill Gorcunov 2020-02-20 14:11 ` Nikita Pettik 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 03/14] box/journal: sanitize completion naming Cyrill Gorcunov 2020-02-20 14:12 ` Nikita Pettik 2020-02-20 14:15 ` Nikita Pettik 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 04/14] box/txn: rename txn_entry_done_cb to txn_entry_complete_cb Cyrill Gorcunov 2020-02-20 14:15 ` Nikita Pettik 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 05/14] box/txn: rename txn_write_to_wal to txn_write_to_wal_async Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 06/14] box/journal: supersede journal_write with journal_write_async Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 07/14] box/txn: rename txn_write to txn_commit_async Cyrill Gorcunov 2020-02-22 20:28 ` Georgy Kirichenko 2020-02-22 21:00 ` Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 08/14] box/txn: move setup of transaction start time to txn_prepare Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 09/14] box/txn: make txn nop processing a separate routine Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 10/14] box/txn: move journal entry allocation into " Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 11/14] box/txn: merge txn_write_to_wal_async to txn_commit_async Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 12/14] box/txn: do not use journal_write_async under the hood Cyrill Gorcunov 2020-02-19 18:37 ` [Tarantool-patches] [PATCH 13/14] box/journal: introduce journal_write Cyrill Gorcunov 2020-02-19 18:37 ` Cyrill Gorcunov [this message] 2020-02-19 19:09 ` [Tarantool-patches] [PATCH 14/14] box/txn: use journal_write in txn_commit Konstantin Osipov 2020-02-19 20:01 ` Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200219183713.17646-15-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 14/14] box/txn: use journal_write in txn_commit' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox