From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 3/4] replication: do not relay rows coming from a remote instance back to it
Date: Tue, 18 Feb 2020 22:07:07 +0300 [thread overview]
Message-ID: <20200218190707.GC20569@atlas> (raw)
In-Reply-To: <ca9dc7cb741083d6f9a45c55acea942435d4daa4.1582046958.git.sergepetrenko@tarantool.org>
* Serge Petrenko <sergepetrenko@tarantool.org> [20/02/18 20:38]:
> vclock_create(&replica_clock);
> bool anon;
> - xrow_decode_subscribe_xc(header, NULL, &replica_uuid,
> - &replica_clock, &replica_version_id, &anon);
> + bool is_orphan;
> + xrow_decode_subscribe_xc(header, NULL, &replica_uuid, &replica_clock,
> + &replica_version_id, &anon, &is_orphan);
Why did you make it so complicated, could you please explain? What
went wrong with my suggestion?
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-02-18 19:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 17:37 [Tarantool-patches] [PATCH v3 0/4] replication: fix applying of rows originating from local instance Serge Petrenko
2020-02-18 17:37 ` [Tarantool-patches] [PATCH v3 1/4] box: expose box_is_orphan method Serge Petrenko
2020-02-18 17:37 ` [Tarantool-patches] [PATCH v3 2/4] recovery: allow to ignore rows coming from a certain instance Serge Petrenko
2020-02-18 19:03 ` Konstantin Osipov
2020-02-19 8:43 ` Serge Petrenko
2020-02-19 8:52 ` Konstantin Osipov
2020-02-19 8:57 ` Serge Petrenko
2020-02-19 9:02 ` Konstantin Osipov
2020-02-19 9:35 ` Serge Petrenko
2020-02-19 10:11 ` Konstantin Osipov
2020-02-19 10:31 ` Serge Petrenko
2020-02-19 11:27 ` Konstantin Osipov
2020-02-18 17:37 ` [Tarantool-patches] [PATCH v3 3/4] replication: do not relay rows coming from a remote instance back to it Serge Petrenko
2020-02-18 19:07 ` Konstantin Osipov [this message]
2020-02-18 17:37 ` [Tarantool-patches] [PATCH v3 4/4] wal: warn when trying to write a record with a broken lsn Serge Petrenko
2020-02-22 20:21 ` [Tarantool-patches] [PATCH v3 0/4] replication: fix applying of rows originating from local instance Georgy Kirichenko
2020-02-22 20:49 ` Konstantin Osipov
2020-02-23 8:16 ` Georgy Kirichenko
2020-02-24 10:18 ` Konstantin Osipov
2020-02-24 12:31 ` Георгий Кириченко
2020-02-26 10:09 ` Sergey Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218190707.GC20569@atlas \
--to=kostja.osipov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 3/4] replication: do not relay rows coming from a remote instance back to it' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox