From: Kirill Yukhin <kyukhin@tarantool.org>
To: olegrok@tarantool.org
Cc: Oleg Babin <babinoleg@mail.ru>,
tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] lua: handle uri.format empty input properly
Date: Tue, 18 Feb 2020 08:23:45 +0300 [thread overview]
Message-ID: <20200218052345.s5l5qve6fxkrb6or@tarantool.org> (raw)
In-Reply-To: <20200215093156.32021-1-olegrok@tarantool.org>
Hello,
On 15 фев 12:31, olegrok@tarantool.org wrote:
> From: Oleg Babin <babinoleg@mail.ru>
>
> After 7fd6c8096343ca254fec10c2ce8a8233ebe47028
> (buffer: port static allocator to Lua) uri started to use
> static_allocator - cyclic buffer that also is used in
> several modules.
>
> However situation then uri.format output is zero-length
> string was not handled properly and ffi.string could
> return data that was previously written in static buffer
> because use as string terminator the first zero byte.
>
> To prevent such situation let's pass result length explicitly.
>
> Closes #4779
I've checked your patch into 2.2, 2.3 and master.
Please, in future accompany your patch w/ a release notes
entry.
Also, please set your e-mail address in git settings to
@tarantool.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-02-18 5:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 9:31 olegrok
2020-02-15 16:15 ` Vladislav Shpilevoy
2020-02-15 17:37 ` Oleg Babin
2020-02-16 15:11 ` Vladislav Shpilevoy
2020-02-18 5:23 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218052345.s5l5qve6fxkrb6or@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=babinoleg@mail.ru \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua: handle uri.format empty input properly' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox