From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] libev: unlimited select flag did not work on mac
Date: Mon, 17 Feb 2020 13:00:40 +0300 [thread overview]
Message-ID: <20200217100040.k6uzft73aqoa7djn@tkn_work_nb> (raw)
In-Reply-To: <20200217074052.GA15384@atlas>
On Mon, Feb 17, 2020 at 10:40:52AM +0300, Konstantin Osipov wrote:
> * Alexander Turenko <alexander.turenko@tarantool.org> [20/02/15 23:22]:
> > > Is it fixed in the upstream? Why is noone complaining in the
> > > upstream? Is there a bug in the upstream?
> >
> > Let me read changelog for you:
>
> Well, I guess the commit comment should say that this is only an
> update from the upstream.
>
> Let me read third_party/README for you!
Touche.
>
> How to update libev
> ===================
>
> Remove Tarantool patches (see csv diff -U8).
> cvs up
> Add patches back.
>
> Did the patch follow the procedure? If it did, it should clearly
> state that it updated libev, and to which version.
Agreed, it makes sense.
>
>
> >
> > | 4.25 Fri Dec 21 07:49:20 CET 2018
> > | <...>
> > | - move the darwin select workaround higher in ev.c, as newer versions of
> > | darwin managed to break their broken select even more.
> >
> > http://cvs.schmorp.de/libev/Changes?view=markup
>
> :/
>
> --
> Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-02-17 10:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 18:45 Maria Khaydich
2020-02-13 0:14 ` Vladislav Shpilevoy
2020-02-15 17:50 ` Konstantin Osipov
2020-02-15 20:19 ` Alexander Turenko
2020-02-17 7:40 ` Konstantin Osipov
2020-02-17 10:00 ` Alexander Turenko [this message]
2020-03-03 14:58 ` [Tarantool-patches] [PATCH] libev: update to version 4.32 Maria Khaydich
2020-04-20 6:30 ` [Tarantool-patches] [PATCH] libev: unlimited select flag did not work on mac Alexander Turenko
2020-04-20 7:59 ` Kirill Yukhin
2020-04-21 17:01 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217100040.k6uzft73aqoa7djn@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] libev: unlimited select flag did not work on mac' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox