Re: [Tarantool-patches] [PATCH v10 3/4] box/applier: prevent nil dereference on applier rollback

[Konstantin Osipov <kostja.osipov@gmail.com>]

* Cyrill Gorcunov <gorcunov@gmail.com> [20/02/15 21:26]:
> > It would be nice to explain in the comment why you want to
> > preserve the original error in the fiber here: because when later
> > this fiber is joined in (add call site here), we may want to check
> > its diagnostics area.
> 
> You know I think we might need to drop replicaset.diag completely
> and use applier.diag instead.

I don't mind, but that could be too intrusive for a bug fix.

I still don't see why you can't patch the crash site - i.e. the
place which joins the fiber with broken diag?


Let me remind you that this is just a regression from the parallel
applier patch, and not a big one - just a coding bug. So let's fix
the coding bug first and refactor the patch second.

> understand this code yet, so I need more time to come with some
> clean solution (which I plan to implement on the top).
> 
> > 
> > >  	/* Broadcast the rollback event across all appliers. */
> > >  	trigger_run(&replicaset.applier.on_rollback, event);
> > >  	/* Rollback applier vclock to the committed one. */


-- 
Konstantin Osipov, Moscow, Russia