Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4 0/4] Safe truncation and deletion
Date: Sat, 15 Feb 2020 00:00:05 +0300	[thread overview]
Message-ID: <20200214210005.GB12053@atlas> (raw)
In-Reply-To: <cover.1581705033.git.i.kosarev@tarantool.org>

* Ilya Kosarev <i.kosarev@tarantool.org> [20/02/14 22:41]:
> Changes in v2:
>   Approach changed completely: now we are not trying to allocate
>   service tuples in some safe way, but increasing memtx quota so
>   that space:truncate() and space:delete() won't fail on allocation.


> 
> Changes in v3:
>   Now we are not increasing memtx quota. Instead we just set a flag to
>   allow quota overuse for space:truncate() and space:delete().
> 
> Changes in v4:
>   improved quota on/off flag style
>   took into account fail cases for box_upsert in space_truncate
>   now we are switching the quota off for deletion only in case there is
>   OutOfMemory error in diag
>   removed extra checks
>   added tests

Is it intentional that first you discuss the
recommendation I make on the mailing list, and then silently
disregard it?

-- 
Konstantin Osipov, Moscow, Russia

  parent reply	other threads:[~2020-02-14 21:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 19:39 Ilya Kosarev
2020-02-14 19:39 ` [Tarantool-patches] [PATCH v4 1/4] small: bump small version Ilya Kosarev
2020-02-14 19:39 ` [Tarantool-patches] [PATCH v4 2/4] b-tree: return NULL on matras_alloc fail Ilya Kosarev
2020-02-14 23:50   ` Vladislav Shpilevoy
2020-02-14 19:39 ` [Tarantool-patches] [PATCH v4 3/4] memtx: allow quota overuse for truncation and deletion Ilya Kosarev
2020-02-14 23:50   ` Vladislav Shpilevoy
2020-02-14 19:39 ` [Tarantool-patches] [PATCH v4 4/4] test: add tests " Ilya Kosarev
2020-02-14 23:50   ` Vladislav Shpilevoy
2020-02-14 21:00 ` Konstantin Osipov [this message]
2020-02-14 21:12   ` [Tarantool-patches] [PATCH v4 0/4] Safe " Ilya Kosarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214210005.GB12053@atlas \
    --to=kostja.osipov@gmail.com \
    --cc=i.kosarev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v4 0/4] Safe truncation and deletion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox