From: Ilya Kosarev <i.kosarev@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Cc: v.shpilevoy@tarantool.org
Subject: [Tarantool-patches] [PATCH] quota: add is_enabled field
Date: Fri, 14 Feb 2020 22:31:56 +0300 [thread overview]
Message-ID: <20200214193156.1279-1-i.kosarev@tarantool.org> (raw)
By default the quota is enabled. If it is set to false, quota_use will
allow to overuse the total available memory limit.
Part of tarantool/tarantool#3807
---
Branch: https://github.com/tarantool/small/tree/i.kosarev/gh-3807-safe-alloc-on-truncation
Issue: https://github.com/tarantool/tarantool/issues/3807
small/quota.h | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/small/quota.h b/small/quota.h
index 3d3b4f0..fbb039e 100644
--- a/small/quota.h
+++ b/small/quota.h
@@ -57,6 +57,12 @@ struct quota {
* QUOTA_UNIT_SIZE.
*/
uint64_t value;
+ /**
+ * By default the quota is enabled. If it is set to
+ * false, quota_use will allow to overuse the total
+ * available memory limit.
+ */
+ bool is_enabled;
};
/**
@@ -68,6 +74,7 @@ quota_init(struct quota *quota, size_t total)
uint64_t new_total = (total + (QUOTA_UNIT_SIZE - 1)) /
QUOTA_UNIT_SIZE;
quota->value = new_total << 32;
+ quota->is_enabled = true;
}
/**
@@ -122,6 +129,12 @@ quota_set(struct quota *quota, size_t new_total)
return new_total_in_units * QUOTA_UNIT_SIZE;
}
+static inline void
+quota_on_off(struct quota *quota, bool is_enabled)
+{
+ quota->is_enabled = is_enabled;
+}
+
/**
* Use up a quota
* @retval > 0 aligned value on success
@@ -143,7 +156,7 @@ quota_use(struct quota *quota, size_t size)
uint32_t new_used_in_units = used_in_units + size_in_units;
assert(new_used_in_units > used_in_units);
- if (new_used_in_units > total_in_units)
+ if (new_used_in_units > total_in_units && quota->is_enabled)
return -1;
uint64_t new_value =
--
2.17.1
next reply other threads:[~2020-02-14 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 19:31 Ilya Kosarev [this message]
2020-02-14 22:48 ` Vladislav Shpilevoy
2020-12-11 15:37 Ilya Kosarev
2020-12-14 23:41 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214193156.1279-1-i.kosarev@tarantool.org \
--to=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] quota: add is_enabled field' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox