From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v8 2/2] fiber: leak slab if unable to bring prots back
Date: Fri, 14 Feb 2020 17:17:04 +0300 [thread overview]
Message-ID: <20200214141704.GA10968@atlas> (raw)
In-Reply-To: <20200214132220.29830-3-gorcunov@gmail.com>
* Cyrill Gorcunov <gorcunov@gmail.com> [20/02/14 16:25]:
> In case if we unable to revert guard page back to
> read|write we should never use such slab again.
>
> Initially I thought of just put panic here and
> exit but it is too destructive. I think better
> print an error and continue. If node admin ignore
> this message then one moment at future there won't
> be slab left for use and creating new fibers get
> prohibited.
>
> In future (hopefully near one) we plan to drop
> guard pages to prevent VMA fracturing and use
> stack marks instead.
Seriously, let's have some decency, first we pushed an optional
feature and then it broke and you're suggestinga hot fix that leaks
memory.
What's the issue with disabling the broken feature?
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-02-14 14:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 13:22 [Tarantool-patches] [PATCH v8 0/2] fiber: Handle stack madvise/mprotect errors Cyrill Gorcunov
2020-02-14 13:22 ` [Tarantool-patches] [PATCH v8 1/2] fiber: set diagnostics at madvise/mprotect failure Cyrill Gorcunov
2020-02-20 21:30 ` Vladislav Shpilevoy
2020-02-14 13:22 ` [Tarantool-patches] [PATCH v8 2/2] fiber: leak slab if unable to bring prots back Cyrill Gorcunov
2020-02-14 14:17 ` Konstantin Osipov [this message]
2020-02-14 14:22 ` Cyrill Gorcunov
2020-02-14 14:29 ` Konstantin Osipov
2020-02-14 14:31 ` Cyrill Gorcunov
2020-02-20 21:00 ` Alexander Turenko
2020-02-21 7:15 ` Konstantin Osipov
2020-02-24 19:25 ` [Tarantool-patches] [PATCH v8 0/2] fiber: Handle stack madvise/mprotect errors Kirill Yukhin
2020-02-24 19:31 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214141704.GA10968@atlas \
--to=kostja.osipov@gmail.com \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v8 2/2] fiber: leak slab if unable to bring prots back' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox