Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@dev.tarantool.org>
Subject: [Tarantool-patches] [PATCH v10 0/4] box/replication: add missing diag set and fix sigsegv
Date: Fri, 14 Feb 2020 17:03:35 +0300	[thread overview]
Message-ID: <20200214140339.4085-1-gorcunov@gmail.com> (raw)

In v10 I tried to sanitize code a bit. Still there are few problems we will
need (well, I'll need) to solve:

 - move error injection deeper into transaction code
 - keep former error
 - make sure that we really need separated replicaset diag instance
   (i must confess i still not follow why we need it)

Anyway with the patch we stop causing nil dereference and write
error log. Same time since I'll have to deal with inmemory wal
task I won't leave these FIXME and continue working on them.

Cyrill Gorcunov (4):
  box/request: add missing OutOfMemory diag_set
  box/applier: add missing diag_set on region_alloc failure
  box/applier: prevent nil dereference on applier rollback
  test: add replication/applier-rollback

 src/box/applier.cc                          |  43 +++++-
 src/box/request.c                           |   8 +-
 src/lib/core/errinj.h                       |   1 +
 test/box/errinj.result                      |   1 +
 test/replication/applier-rollback-slave.lua |  16 ++
 test/replication/applier-rollback.result    | 160 ++++++++++++++++++++
 test/replication/applier-rollback.test.lua  |  79 ++++++++++
 test/replication/suite.ini                  |   2 +-
 8 files changed, 305 insertions(+), 5 deletions(-)
 create mode 100644 test/replication/applier-rollback-slave.lua
 create mode 100644 test/replication/applier-rollback.result
 create mode 100644 test/replication/applier-rollback.test.lua


base-commit: 95b9a48daf00b6686b8e1993a023daa0755b460e
-- 
2.20.1

             reply	other threads:[~2020-02-14 14:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 14:03 Cyrill Gorcunov [this message]
2020-02-14 14:03 ` [Tarantool-patches] [PATCH v10 1/4] box/request: add missing OutOfMemory diag_set Cyrill Gorcunov
2020-02-15 17:33   ` Konstantin Osipov
2020-02-14 14:03 ` [Tarantool-patches] [PATCH v10 2/4] box/applier: add missing diag_set on region_alloc failure Cyrill Gorcunov
2020-02-15 17:34   ` Konstantin Osipov
2020-02-14 14:03 ` [Tarantool-patches] [PATCH v10 3/4] box/applier: prevent nil dereference on applier rollback Cyrill Gorcunov
2020-02-15 17:37   ` Konstantin Osipov
2020-02-15 18:24     ` Cyrill Gorcunov
2020-02-15 18:51       ` Konstantin Osipov
2020-02-14 14:03 ` [Tarantool-patches] [PATCH v10 4/4] test: add replication/applier-rollback Cyrill Gorcunov
2020-02-15 17:38   ` Konstantin Osipov
2020-02-15 17:59     ` Cyrill Gorcunov
2020-02-14 14:12 ` [Tarantool-patches] [PATCH v10 0/4] box/replication: add missing diag set and fix sigsegv Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214140339.4085-1-gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v10 0/4] box/replication: add missing diag set and fix sigsegv' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox