From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 2/2] fiber: leak slab if unable to bring prots back
Date: Thu, 13 Feb 2020 11:20:39 +0300 [thread overview]
Message-ID: <20200213082039.GN21061@uranus> (raw)
In-Reply-To: <90607bfb-8f31-765f-ae8d-7cdb34598b0c@tarantool.org>
On Thu, Feb 13, 2020 at 01:08:45AM +0100, Vladislav Shpilevoy wrote:
> > - diag_log();
> > + say_syserror("fiber: Can't put guard page to slab. "
> > + "Leak %zu bytes", (size_t)fiber->stack_size);
>
> This behaviour actually should be testable, no? You could not test
> diag, but you should be able to detect a leak. Using slab_cache_used(),
> for example. Before and after a test.
Will try, thanks!
next prev parent reply other threads:[~2020-02-13 8:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 12:31 [Tarantool-patches] [PATCH v6 0/2] fiber: Handle stack madvise/mprotect errors Cyrill Gorcunov
2020-02-06 12:31 ` [Tarantool-patches] [PATCH v6 1/2] fiber: set diagnostics at madvise/mprotect failure Cyrill Gorcunov
2020-02-13 0:08 ` Vladislav Shpilevoy
2020-02-13 8:19 ` Cyrill Gorcunov
2020-02-13 23:26 ` Vladislav Shpilevoy
2020-02-14 7:56 ` Cyrill Gorcunov
2020-02-06 12:31 ` [Tarantool-patches] [PATCH v6 2/2] fiber: leak slab if unable to bring prots back Cyrill Gorcunov
2020-02-13 0:08 ` Vladislav Shpilevoy
2020-02-13 8:20 ` Cyrill Gorcunov [this message]
2020-02-09 17:39 ` [Tarantool-patches] [PATCH v6 0/2] fiber: Handle stack madvise/mprotect errors Vladislav Shpilevoy
2020-02-09 18:34 ` Cyrill Gorcunov
2020-02-13 0:07 ` Vladislav Shpilevoy
2020-02-13 7:16 ` Cyrill Gorcunov
2020-02-20 19:25 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213082039.GN21061@uranus \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6 2/2] fiber: leak slab if unable to bring prots back' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox