From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 3/4] sql: fix CAST AS NUMBER operator
Date: Wed, 12 Feb 2020 17:10:42 +0300 [thread overview]
Message-ID: <20200212141042.GD8095@tarantool.org> (raw)
In-Reply-To: <ff636f21-aa9e-4486-4ad8-aab63e01c578@tarantool.org>
On 12 Feb 00:27, Vladislav Shpilevoy wrote:
> On 12/02/2020 00:20, Nikita Pettik wrote:
> > On 11 Feb 23:17, Vladislav Shpilevoy wrote:
> >> Hi!
> >>
> >> I've pushed my review fixes on top of this commit. See it in the
> >> end of the email, and on the branch.
> >>
> >> 3.2 and 3.13 still were the same, I dropped 3.13.
> >
> > Don't bother with such insignificant things, I am always ok with these fixes.
> > Just amend them and force push already squashed :)
>
> Ok, will take that into account next time
>
> > Ofc I've applied your fixes, thanks.
>
> The patchset LGTM then.
Pushed to master only. Milestone for this issue is 2.2.3, but 2.2 lacks
DOUBLE type, so patches can't be applied.
I did not push to 2.3 since I don't consider this issue to be a bug,
but rather behaviour change in type system. However, if somebody
insists on adding this change to 2.3 then I won't mind.
next prev parent reply other threads:[~2020-02-12 14:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 16:19 [Tarantool-patches] [PATCH 0/4] sql: fix NUMBER conversion issues Nikita Pettik
2020-02-05 16:19 ` [Tarantool-patches] [PATCH 1/4] sql: remove cast to INT during FP arithmetic ops Nikita Pettik
2020-02-05 16:19 ` [Tarantool-patches] [PATCH 2/4] sql: refactor sqlVdbeMemNumerify() Nikita Pettik
2020-02-10 23:25 ` Vladislav Shpilevoy
2020-02-11 14:14 ` Nikita Pettik
2020-02-11 22:17 ` Vladislav Shpilevoy
2020-02-05 16:19 ` [Tarantool-patches] [PATCH 3/4] sql: fix CAST AS NUMBER operator Nikita Pettik
2020-02-10 23:24 ` Vladislav Shpilevoy
2020-02-11 14:14 ` Nikita Pettik
2020-02-11 22:17 ` Vladislav Shpilevoy
2020-02-11 23:20 ` Nikita Pettik
2020-02-11 23:27 ` Vladislav Shpilevoy
2020-02-12 14:10 ` Nikita Pettik [this message]
2020-02-05 16:19 ` [Tarantool-patches] [PATCH 4/4] sql: do not force FP representation for NUMBER field Nikita Pettik
2020-02-10 23:24 ` Vladislav Shpilevoy
2020-02-11 14:14 ` Nikita Pettik
2020-02-09 17:39 ` [Tarantool-patches] [PATCH 0/4] sql: fix NUMBER conversion issues Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212141042.GD8095@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 3/4] sql: fix CAST AS NUMBER operator' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox