Re: [Tarantool-patches] [PATCH 3/4] sql: fix CAST AS NUMBER operator

[Nikita Pettik <korablev@tarantool.org>]

On 11 Feb 23:17, Vladislav Shpilevoy wrote:
> Hi!
> 
> I've pushed my review fixes on top of this commit. See it in the
> end of the email, and on the branch.
> 
> 3.2 and 3.13 still were the same, I dropped 3.13.

Don't bother with such insignificant things, I am always ok with these fixes.
Just amend them and force push already squashed :)

Ofc I've applied your fixes, thanks.

> ================================================================================
> 
> commit 6f1ce3265cab561c7d4959bd1a1998a986287da7
> Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Date:   Tue Feb 11 23:14:48 2020 +0100
> 
>     Review fix
> 
> diff --git a/test/sql-tap/cast.test.lua b/test/sql-tap/cast.test.lua
> index d4af339fd..fb0790d04 100755
> --- a/test/sql-tap/cast.test.lua
> +++ b/test/sql-tap/cast.test.lua
> @@ -1,6 +1,6 @@
>  #!/usr/bin/env tarantool
>  test = require("sqltester")
> -test:plan(80)
> +test:plan(79)
>  
>  --!./tcltestrunner.lua
>  -- 2005 June 25
> @@ -682,11 +682,6 @@ test:do_execsql_test(
>          -- </cast-3.12>
>      })
>  
> -test:do_execsql_test(
> -    "cast-3.13",
> -    "SELECT CAST(9223372036854774800 AS NUMBER)",
> -    {9223372036854774800LL})
> -
>  test:do_execsql_test(
>      "cast-3.14",
>      [[