Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: fix bug <IN> type mismatch error
Date: Mon, 10 Feb 2020 16:48:27 +0300	[thread overview]
Message-ID: <20200210134827.GG1110@tarantool.org> (raw)
In-Reply-To: <20200210105438.GA3715@tarantool.org>

On 10 Feb 13:54, Mergen Imeev wrote:
> Hello! Thanks for the patch. In general, I think that part of the
> problem will be solved along with the solution to problem #4230
> ("sql: implicit type cast during comparison"). But since #4230 is
> still under discussion, it might be better to fix the bug with
> your patch. Still, I think that most of this patch will be
> rewritten in #4230.

Guys, result of IN operation must be equal (in all senses) to the result
of one-by-one explicit comparisons:

SELECT true IN (1, 2, 3);  <==> SELECT true == 1 OR true == 2 OR true == 3;

The latter raises an error, since there's no implicit conversion between
booleans and numerics. Hence, the goal of issue not only to make results
IN operations be equal, but rather make it return the same correct result
(i.e. as comparison does).
 

      reply	other threads:[~2020-02-10 13:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 11:34 Roman Khabibov
2020-02-10 10:54 ` Mergen Imeev
2020-02-10 13:48   ` Nikita Pettik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200210134827.GG1110@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] sql: fix bug <IN> type mismatch error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox