From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 2/2] memtx: allow quota overuse for truncation and deletion
Date: Mon, 10 Feb 2020 12:49:24 +0300 [thread overview]
Message-ID: <20200210094924.GA920@atlas> (raw)
In-Reply-To: <1581323070.966721067@f426.i.mail.ru>
* Ilya Kosarev <i.kosarev@tarantool.org> [20/02/10 11:26]:
>
> As far as i see, memtx reserves extents using specific pool and
> mempool_alloc. We will need to implement additional feature to reserve
> slabs in memtx arena and provide them specifically for truncation
> needs.
Yes. But the way you say it sounds negative. Are you suggesting
not implementing this feature and just hacking in quota bypass is
better? Why?
> However, after that we will encounter the necessity to calculate
> how much space we need to reserve for truncation tuples.
No. 1 slab is enough.
> I guess we
> might want to reserve a truncation buf for each created space and
> re-reserve it on each truncation, although such logic seems
> overcomplicated.
Indeed, this would be strange.
> Furthermore, the problem with space:delete() might happen exactly when
> we are trying to reserve a slab to guarantee successful statement-level
> rollback. This can't be fixed using reservation tech.
Two events can't happen at the same time in a single-threaded
application. Please take time to explain what you mean here.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-02-10 9:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 18:13 [Tarantool-patches] [PATCH v3 0/2] Safe " Ilya Kosarev
2020-01-20 18:13 ` [Tarantool-patches] [PATCH v3 1/2] b-tree: return NULL on matras_alloc fail Ilya Kosarev
2020-01-21 10:32 ` Nikita Pettik
2020-01-31 8:18 ` Konstantin Osipov
2020-02-04 17:13 ` Nikita Pettik
2020-02-04 17:25 ` Konstantin Osipov
2020-02-04 18:08 ` Nikita Pettik
2020-02-04 18:25 ` Konstantin Osipov
2020-01-21 20:55 ` Vladislav Shpilevoy
2020-01-20 18:13 ` [Tarantool-patches] [PATCH v3 2/2] memtx: allow quota overuse for truncation and deletion Ilya Kosarev
2020-01-21 11:42 ` Nikita Pettik
2020-01-21 20:59 ` Vladislav Shpilevoy
2020-02-14 19:57 ` Ilya Kosarev
2020-01-31 8:21 ` Konstantin Osipov
2020-02-04 18:56 ` Ilya Kosarev
2020-02-04 20:06 ` Konstantin Osipov
2020-02-05 19:11 ` Ilya Kosarev
2020-02-05 19:17 ` Konstantin Osipov
2020-02-06 10:50 ` Ilya Kosarev
2020-02-06 14:29 ` Konstantin Osipov
2020-02-06 16:14 ` Ilya Kosarev
2020-02-06 16:26 ` Konstantin Osipov
2020-02-10 8:24 ` Ilya Kosarev
2020-02-10 9:49 ` Konstantin Osipov [this message]
2020-02-10 10:43 ` Ilya Kosarev
2020-02-10 10:50 ` Konstantin Osipov
2020-02-14 19:55 ` Ilya Kosarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210094924.GA920@atlas \
--to=kostja.osipov@gmail.com \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 2/2] memtx: allow quota overuse for truncation and deletion' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox