From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: fix off-by-one error while setting bind names
Date: Thu, 6 Feb 2020 20:30:18 +0300 [thread overview]
Message-ID: <20200206173018.GB27490@tarantool.org> (raw)
In-Reply-To: <ace1be7a-6745-ae5a-b3dd-ce84b248a761@tarantool.org>
On 04 Feb 22:36, Vladislav Shpilevoy wrote:
> Hi!
>
> Thanks for the patch, LGTM.
Pushed to master and 2.3
> On 04/02/2020 18:12, Nikita Pettik wrote:
> > Names of bindings are stored in the array indexed from 1 (see struct
> > Vdbe->pVList). So to get name of i-th values to be bound, one should
> > call sqlVListNumToName(list, i+1) not sqlVListNumToName(list, i).
> > For this reason, names of binding parameters returned in meta-information
> > in response to :prepare() call are shifted by one. Let's fix it and
> > calculate position of binding parameter taking into consideration
> > 1-based indexing.
> >
> > Closes #4760
> > ---
> > Branch: https://github.com/tarantool/tarantool/commits/np/gh-4760-off-by-one-bind
> > Issue: https://github.com/tarantool/tarantool/issues/4760
prev parent reply other threads:[~2020-02-06 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 17:12 Nikita Pettik
2020-02-04 21:36 ` Vladislav Shpilevoy
2020-02-06 17:30 ` Nikita Pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206173018.GB27490@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] sql: fix off-by-one error while setting bind names' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox