Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [Tarantool-patches] [PATCH v6 0/2] fiber: Handle stack madvise/mprotect errors
Date: Thu,  6 Feb 2020 15:31:12 +0300	[thread overview]
Message-ID: <20200206123114.8010-1-gorcunov@gmail.com> (raw)

Sasha, I put your reviewed-by tag, please let me know if
you're not agreed.

Vlad, take a look please once time permit.

v6 (by @alexander.turenko):
 - polish unit test (style and results)
 - fix bracing in core/fiber.c

issue https://github.com/tarantool/tarantool/issues/4722
branch gorcunov/gh-4722-mprotect-diag-error-6

Cyrill Gorcunov (2):
  fiber: set diagnostics at madvise/mprotect failure
  fiber: leak slab if unable to bring prots back

 src/lib/core/errinj.h        |   2 +
 src/lib/core/fiber.c         |  93 +++++++++++++++++++-----
 test/box/errinj.result       | 136 ++++++++++++++++++-----------------
 test/unit/CMakeLists.txt     |   4 ++
 test/unit/fiber_stack.cc     |  83 +++++++++++++++++++++
 test/unit/fiber_stack.result |   7 ++
 test/unit/suite.ini          |   2 +-
 7 files changed, 242 insertions(+), 85 deletions(-)
 create mode 100644 test/unit/fiber_stack.cc
 create mode 100644 test/unit/fiber_stack.result

-- 
2.20.1

             reply	other threads:[~2020-02-06 12:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 12:31 Cyrill Gorcunov [this message]
2020-02-06 12:31 ` [Tarantool-patches] [PATCH v6 1/2] fiber: set diagnostics at madvise/mprotect failure Cyrill Gorcunov
2020-02-13  0:08   ` Vladislav Shpilevoy
2020-02-13  8:19     ` Cyrill Gorcunov
2020-02-13 23:26       ` Vladislav Shpilevoy
2020-02-14  7:56         ` Cyrill Gorcunov
2020-02-06 12:31 ` [Tarantool-patches] [PATCH v6 2/2] fiber: leak slab if unable to bring prots back Cyrill Gorcunov
2020-02-13  0:08   ` Vladislav Shpilevoy
2020-02-13  8:20     ` Cyrill Gorcunov
2020-02-09 17:39 ` [Tarantool-patches] [PATCH v6 0/2] fiber: Handle stack madvise/mprotect errors Vladislav Shpilevoy
2020-02-09 18:34   ` Cyrill Gorcunov
2020-02-13  0:07 ` Vladislav Shpilevoy
2020-02-13  7:16   ` Cyrill Gorcunov
2020-02-20 19:25 ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200206123114.8010-1-gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v6 0/2] fiber: Handle stack madvise/mprotect errors' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox