Re: [Tarantool-patches] [PATCH v5 0/2] fiber: Handle stack madvise/mprotect errors

[Alexander Turenko <alexander.turenko@tarantool.org>]

LGTM (except several minor points; fixes for them are obvious and it is
not necessary to re-review the patchset with me).

Please, fix those points and send the patch to Vlad for the second
review.

WBR, Alexander Turenko.

On Thu, Feb 06, 2020 at 01:06:22AM +0300, Cyrill Gorcunov wrote:
> issue https://github.com/tarantool/tarantool/issues/4722
> branch gorcunov/gh-4722-mprotect-diag-error-5
> 
> In v5:
>  - merged errinj together with test into the patch itself
>  - on guard page restore we print error and continue instead
>    of immeadiate exit
> 
> Cyrill Gorcunov (2):
>   fiber: use diag_ logger in fiber_madvise/mprotect failures
>   fiber: leak slab if unable to bring prots back
> 
>  src/lib/core/errinj.h        |    2 +
>  src/lib/core/fiber.c         |   92 +-
>  test/box/errinj.result       | 2616 ++++++++++++++++++----------------
>  test/unit/CMakeLists.txt     |    4 +
>  test/unit/fiber_stack.cc     |   83 ++
>  test/unit/fiber_stack.result |    6 +
>  test/unit/suite.ini          |    2 +-
>  7 files changed, 1530 insertions(+), 1275 deletions(-)
>  create mode 100644 test/unit/fiber_stack.cc
>  create mode 100644 test/unit/fiber_stack.result
> 
> -- 
> 2.20.1
>