From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v7 2/5] box/applier: add missing diag_set on region_alloc failure
Date: Wed, 5 Feb 2020 01:15:56 +0300 [thread overview]
Message-ID: <20200204221556.GE20146@atlas> (raw)
In-Reply-To: <20200203143928.GG547@tarantool.org>
* Sergey Ostanevich <sergos@tarantool.org> [20/02/03 17:42]:
> Hi!
>
> Thanks for the patch!
>
> LGTM.
This code is dead actually. There is no region quota and OOM is
impossible here. We haven't had a policy to check these errors
before.
No harm in pushing it, but no value either.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-02-04 22:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 19:22 [Tarantool-patches] [PATCH v7 0/5] box/replication: add missing diag set and fix sigsegv Cyrill Gorcunov
2020-01-28 19:22 ` [Tarantool-patches] [PATCH v7 1/5] box/request: add missing OutOfMemory diag_set Cyrill Gorcunov
2020-02-03 14:37 ` Sergey Ostanevich
2020-01-28 19:22 ` [Tarantool-patches] [PATCH v7 2/5] box/applier: add missing diag_set on region_alloc failure Cyrill Gorcunov
2020-02-03 14:39 ` Sergey Ostanevich
2020-02-04 22:15 ` Konstantin Osipov [this message]
2020-02-05 7:46 ` Cyrill Gorcunov
2020-02-05 9:49 ` Konstantin Osipov
2020-02-05 10:06 ` Cyrill Gorcunov
2020-01-28 19:22 ` [Tarantool-patches] [PATCH v7 3/5] box/applier: fix nil dereference in applier rollback Cyrill Gorcunov
2020-02-04 22:19 ` Konstantin Osipov
2020-02-05 7:33 ` Cyrill Gorcunov
2020-01-28 19:22 ` [Tarantool-patches] [PATCH v7 4/5] errinj: add ERRINJ_REPLICA_TXN_WRITE Cyrill Gorcunov
2020-02-04 22:45 ` Konstantin Osipov
2020-01-28 19:22 ` [Tarantool-patches] [PATCH v7 5/5] test: add replication/applier-rollback Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204221556.GE20146@atlas \
--to=kostja.osipov@gmail.com \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v7 2/5] box/applier: add missing diag_set on region_alloc failure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox