From: Nikita Pettik <korablev@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
Ilya Kosarev <i.kosarev@tarantool.org>,
tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 1/2] b-tree: return NULL on matras_alloc fail
Date: Tue, 4 Feb 2020 20:13:42 +0300 [thread overview]
Message-ID: <20200204171342.GC62548@tarantool.org> (raw)
In-Reply-To: <20200131081855.GB10740@atlas>
On 31 Jan 11:18, Konstantin Osipov wrote:
> * Nikita Pettik <korablev@tarantool.org> [20/01/21 13:37]:
> > On 20 Jan 21:13, Ilya Kosarev wrote:
> > > In bps_tree_create_leaf we use matras_alloc in case
> > > bps_tree_garbage_pop didn't work out. However it also might not
> > > succeed. Then we need to return NULL instead of dereferencing NULL
> > > pointer.
>
> I don't understand the attempt to fix it.
>
> The reason the allocations are not checked - most likely -because
> BPS should refuse to even begin an operation if there is not
> enough memory in matras.
According to the code it doesn't look so. Matras allocation checked
on fails, except two ones in bps_tree_create_inner() and
bps_tree_create_leaf().
> Most likely Alexander Lyapunov was relying on that, and this is why you
> don't have these checks all over bps code.>
>
> --
> Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-02-04 17:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 18:13 [Tarantool-patches] [PATCH v3 0/2] Safe truncation and deletion Ilya Kosarev
2020-01-20 18:13 ` [Tarantool-patches] [PATCH v3 1/2] b-tree: return NULL on matras_alloc fail Ilya Kosarev
2020-01-21 10:32 ` Nikita Pettik
2020-01-31 8:18 ` Konstantin Osipov
2020-02-04 17:13 ` Nikita Pettik [this message]
2020-02-04 17:25 ` Konstantin Osipov
2020-02-04 18:08 ` Nikita Pettik
2020-02-04 18:25 ` Konstantin Osipov
2020-01-21 20:55 ` Vladislav Shpilevoy
2020-01-20 18:13 ` [Tarantool-patches] [PATCH v3 2/2] memtx: allow quota overuse for truncation and deletion Ilya Kosarev
2020-01-21 11:42 ` Nikita Pettik
2020-01-21 20:59 ` Vladislav Shpilevoy
2020-02-14 19:57 ` Ilya Kosarev
2020-01-31 8:21 ` Konstantin Osipov
2020-02-04 18:56 ` Ilya Kosarev
2020-02-04 20:06 ` Konstantin Osipov
2020-02-05 19:11 ` Ilya Kosarev
2020-02-05 19:17 ` Konstantin Osipov
2020-02-06 10:50 ` Ilya Kosarev
2020-02-06 14:29 ` Konstantin Osipov
2020-02-06 16:14 ` Ilya Kosarev
2020-02-06 16:26 ` Konstantin Osipov
2020-02-10 8:24 ` Ilya Kosarev
2020-02-10 9:49 ` Konstantin Osipov
2020-02-10 10:43 ` Ilya Kosarev
2020-02-10 10:50 ` Konstantin Osipov
2020-02-14 19:55 ` Ilya Kosarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204171342.GC62548@tarantool.org \
--to=korablev@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 1/2] b-tree: return NULL on matras_alloc fail' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox