From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] fiber: use diag_ logger in fiber_madvise/mprotect failures
Date: Tue, 4 Feb 2020 01:05:20 +0300 [thread overview]
Message-ID: <20200203220520.GB12445@uranus> (raw)
In-Reply-To: <20200203215627.l55b6rikwubeaqvn@tkn_work_nb>
On Tue, Feb 04, 2020 at 12:56:27AM +0300, Alexander Turenko wrote:
> Everything looks correct.
>
> However, I don't believe my eyes, so I wrote a test case (see below).
>
> Don't sure whether it is good to have error injections for such
> functions. Maybe LD_PRELOAD way is better (see [1]). Anyway, I checked
> that the behaviour was incorrect using the test and that it becomes
> correct.
>
> Please, consider the shared test and decide whether it worth to add it
> to the repository (I don't sure).
I think having errinj is better in a long term, it is controllable
by our code and doesn't depend on any other hooks. Except
- I would call it just FIBER_MPROTECT (without prot-none suffix)
- iirc there was some test in app/ errinj or similar which should
be updated everytime new errinj introduced.
With this two things addressed feel free to put my Ack. And thanks
a huge, Sasha, for this test
next prev parent reply other threads:[~2020-02-03 22:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 17:05 [Tarantool-patches] [PATCH v2 0/2] fiber: Handle stack madvise/mprotect errors Cyrill Gorcunov
2020-01-15 17:05 ` [Tarantool-patches] [PATCH v2 1/2] fiber: use diag_ logger in fiber_madvise/mprotect failures Cyrill Gorcunov
2020-02-03 21:56 ` Alexander Turenko
2020-02-03 22:05 ` Cyrill Gorcunov [this message]
2020-02-03 22:10 ` Alexander Turenko
2020-01-15 17:05 ` [Tarantool-patches] [PATCH v2 2/2] fiber: exit with panic if we unable to revert guard page Cyrill Gorcunov
2020-02-03 22:03 ` Alexander Turenko
2020-02-04 15:47 ` Konstantin Osipov
2020-02-04 16:08 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203220520.GB12445@uranus \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] fiber: use diag_ logger in fiber_madvise/mprotect failures' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox