From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] box/txn: do not zap fiber txn pointer before txn_write_to_wal completes
Date: Fri, 31 Jan 2020 22:57:23 +0300 [thread overview]
Message-ID: <20200131195723.GA12445@uranus> (raw)
In-Reply-To: <20200131194448.GA17326@atlas>
On Fri, Jan 31, 2020 at 10:44:48PM +0300, Konstantin Osipov wrote:
>
> I believe Georgy added this for a reason - since the current fiber
> is no longer locked until the transaction is resumed, it should
> be removed from the fiber key (this change AFAIU comes from
> parallel applier patch).
>
> I suggest you move this statement inside txn_write_to_wal(). I
> can't find a good place for it yet though.
Thanks for idea, Kostya! The my patch above didn't work simply
because if I don't set NULL here it start triggering assertion
in another places. IOW, I filed this issue and will back to
it on the next week I hope. I'll show you the result.
next prev parent reply other threads:[~2020-01-31 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 15:17 Cyrill Gorcunov
2020-01-24 15:24 ` Cyrill Gorcunov
2020-01-31 19:44 ` Konstantin Osipov
2020-01-31 19:57 ` Cyrill Gorcunov [this message]
2020-02-03 19:54 ` Georgy Kirichenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131195723.GA12445@uranus \
--to=gorcunov@gmail.com \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] box/txn: do not zap fiber txn pointer before txn_write_to_wal completes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox